public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Rosin <peda@axentia.se>
To: Biwen Li <biwen.li@nxp.com>,
	"leoyang.li@nxp.com" <leoyang.li@nxp.com>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: i2c: replace property i2c-mux-idle-disconnect
Date: Mon, 14 Oct 2019 15:44:54 +0000	[thread overview]
Message-ID: <4124752f-19a2-e3c1-7887-07ba66a79c29@axentia.se> (raw)
In-Reply-To: <20191014112558.3881-1-biwen.li@nxp.com>

On 2019-10-14 13:25, Biwen Li wrote:
> This replaces property i2c-mux-idle-disconnect with idle-state
> 
> Signed-off-by: Biwen Li <biwen.li@nxp.com>
> ---
>  Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> index 30ac6a60f041..f2db517b1635 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mux-pca954x.txt
> @@ -25,9 +25,7 @@ Required Properties:
>  Optional Properties:
>  
>    - reset-gpios: Reference to the GPIO connected to the reset input.
> -  - i2c-mux-idle-disconnect: Boolean; if defined, forces mux to disconnect all
> -    children in idle state. This is necessary for example, if there are several
> -    multiplexers on the bus and the devices behind them use same I2C addresses.
> +  - idle-state: Please refer to Documentation/devicetree/bindings/mux/mux-controller.txt
>    - interrupts: Interrupt mapping for IRQ.
>    - interrupt-controller: Marks the device node as an interrupt controller.
>    - #interrupt-cells : Should be two.
> 

You can't just remove i2c-mux-idle-disconnect. It needs to remain, and the
driver needs to maintain support for this in case a new kernel is running
with an old devicetree.

Cheers,
Peter

  parent reply	other threads:[~2019-10-14 15:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-14 11:25 [PATCH 1/2] dt-bindings: i2c: replace property i2c-mux-idle-disconnect Biwen Li
2019-10-14 11:25 ` [PATCH 2/2] i2c: mux: pca954x: " Biwen Li
2019-10-14 16:03   ` Peter Rosin
2019-10-15  3:17     ` [EXT] " Biwen Li
2019-10-14 11:41 ` [PATCH 1/2] dt-bindings: i2c: " Biwen Li
2019-10-14 15:44 ` Peter Rosin [this message]
2019-10-15  3:18   ` [EXT] " Biwen Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4124752f-19a2-e3c1-7887-07ba66a79c29@axentia.se \
    --to=peda@axentia.se \
    --cc=biwen.li@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox