From: "Hawa, Hanna" <hhhawa@amazon.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <wsa@kernel.org>, <jarkko.nikula@linux.intel.com>,
<mika.westerberg@linux.intel.com>, <jsd@semihalf.com>,
<linus.walleij@linaro.org>, <ben-linux@fluff.org>,
<linux-i2c@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<dwmw@amazon.co.uk>, <benh@amazon.com>, <ronenk@amazon.com>,
<talel@amazon.com>, <jonnyc@amazon.com>, <hanochu@amazon.com>,
<farbere@amazon.com>, <itamark@amazon.com>,
Lareine Khawaly <lareine@amazon.com>
Subject: Re: [PATCH v4 1/1] i2c: designware: use casting of u64 in clock multiplication to avoid overflow
Date: Tue, 20 Dec 2022 21:43:25 +0200 [thread overview]
Message-ID: <42585223-2d92-5a9e-3707-d5e70fe6937b@amazon.com> (raw)
In-Reply-To: <Y6IMhZsbOk/J9xZB@smile.fi.intel.com>
On 12/20/2022 9:27 PM, Andy Shevchenko wrote:
> Thinking more on this, I would probably replace the order of arguments to make
> it ' + offset - N' in each case. Since plus will be on the previous line and
> become first it will be easier to parse the arithmetical expression.
Do you want this change in the same patch? i don't think it's related
here.. I can push separated change
Thanks,
Hanna
next prev parent reply other threads:[~2022-12-20 19:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-20 16:48 [PATCH v4 1/1] i2c: designware: use casting of u64 in clock multiplication to avoid overflow Hanna Hawa
2022-12-20 17:11 ` Andy Shevchenko
2022-12-20 17:13 ` Andy Shevchenko
2022-12-20 17:43 ` Hawa, Hanna
2022-12-20 19:23 ` Andy Shevchenko
2022-12-20 19:27 ` Andy Shevchenko
2022-12-20 19:43 ` Hawa, Hanna [this message]
2022-12-21 16:59 ` Andy Shevchenko
2022-12-21 19:54 ` Hawa, Hanna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42585223-2d92-5a9e-3707-d5e70fe6937b@amazon.com \
--to=hhhawa@amazon.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ben-linux@fluff.org \
--cc=benh@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=itamark@amazon.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jonnyc@amazon.com \
--cc=jsd@semihalf.com \
--cc=lareine@amazon.com \
--cc=linus.walleij@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox