From: Nishanth Menon <nm@ti.com>
To: "G, Manjunath Kondaiah" <manjugk@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"ben-linux@fluff.org" <ben-linux@fluff.org>,
"Kalliguddi, Hema" <hemahk@ti.com>,
Aaro Koskinen <Aaro.Koskinen@nokia.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH v6] OMAP2/3: I2C: Errata ID i207: Clear wrong RDR interrupt
Date: Wed, 28 Apr 2010 05:22:59 -0500 [thread overview]
Message-ID: <4BD80C83.8080903@ti.com> (raw)
In-Reply-To: <E0D41E29EB0DAC4E9F3FF173962E9E94026F78A00B@dbde02.ent.ti.com>
On 04/28/2010 05:20 AM, G, Manjunath Kondaiah wrote:
[..]
>>>
>>> + dev->errata = 0;
>>> +
>>> + if (cpu_is_omap2430() || cpu_is_omap34xx())
>> ^^^^^^^^ wont cpu_is_omap24xx() cover omap2420 as
>> well? I think it might be better using that.. apologies on
>> missing it in
>> the last look.
>
> This errata is not applicable for 2420 and it is applicable for:
> 1. omap2430
> 2. omap34xx(including omap3630).
>
> Sorry. My earlier patch was using this errata logic for all omap's
> except omap4 which was wrong(for omap2420 and omap1 - not sure, I don't have
> any data hence ignoring this errata for omap1 also).
>
Could you fix your commit message to state so instead of using OMAP2?
thanks.. I think we are almost close to the final rev is Tony is ok as
well.. Thanks for hanging in there..
[...]
Regards,
Nishanth Menon
next prev parent reply other threads:[~2010-04-28 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-28 5:47 [PATCH v6] OMAP2/3: I2C: Errata ID i207: Clear wrong RDR interrupt Manjunatha GK
[not found] ` <1272433677-28658-1-git-send-email-manjugk-l0cyMroinI0@public.gmane.org>
2010-04-28 10:05 ` Nishanth Menon
[not found] ` <4BD80867.7020801-l0cyMroinI0@public.gmane.org>
2010-04-28 10:20 ` G, Manjunath Kondaiah
2010-04-28 10:22 ` Nishanth Menon [this message]
2010-04-28 14:17 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BD80C83.8080903@ti.com \
--to=nm@ti.com \
--cc=Aaro.Koskinen@nokia.com \
--cc=ben-linux@fluff.org \
--cc=hemahk@ti.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=manjugk@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox