[PATCH 3/4] i2c-nomadik: support smbus emulation

[PATCH 3/4] i2c-nomadik: support smbus emulation

[Linus Walleij]

We can do smbus emulation so flag this and drop the duplicate
flags implied from smbus emulation.

Acked-by: Srinidhi Kasagar <srinidhi.kasagar-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Signed-off-by: Sundar R Iyer <sundar.iyer-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
Signed-off-by: Linus Walleij <linus.walleij-0IS4wlFg1OjSUeElwK9/Pw@public.gmane.org>
---
 drivers/i2c/busses/i2c-nomadik.c |    5 +----
 1 files changed, 1 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/busses/i2c-nomadik.c b/drivers/i2c/busses/i2c-nomadik.c
index b2dbf7c..e461de7 100644
--- a/drivers/i2c/busses/i2c-nomadik.c
+++ b/drivers/i2c/busses/i2c-nomadik.c
@@ -803,10 +803,7 @@ static irqreturn_t i2c_irq_handler(int irq, void *arg)
 
 static unsigned int nmk_i2c_functionality(struct i2c_adapter *adap)
 {
-	return I2C_FUNC_I2C
-		| I2C_FUNC_SMBUS_BYTE_DATA
-		| I2C_FUNC_SMBUS_WORD_DATA
-		| I2C_FUNC_SMBUS_I2C_BLOCK;
+	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
 }
 
 static const struct i2c_algorithm nmk_i2c_algo = {
-- 
1.6.3.3

Re: [PATCH 3/4] i2c-nomadik: support smbus emulation

[Shinya Kuribayashi]

On 9/23/2010 4:04 PM, Linus Walleij wrote:
> We can do smbus emulation so flag this and drop the duplicate
> flags implied from smbus emulation.

> @@ -803,10 +803,7 @@ static irqreturn_t i2c_irq_handler(int irq, void *arg)
>  
>  static unsigned int nmk_i2c_functionality(struct i2c_adapter *adap)
>  {
> -	return I2C_FUNC_I2C
> -		| I2C_FUNC_SMBUS_BYTE_DATA
> -		| I2C_FUNC_SMBUS_WORD_DATA
> -		| I2C_FUNC_SMBUS_I2C_BLOCK;
> +	return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
>  }
>  
>  static const struct i2c_algorithm nmk_i2c_algo = {

(failed to figure out from the driver, so would like to make sure)
Is this I2C core capable of I2C_FUNC_SMBUS_QUICK?  Unless it's capable
of full SMBus emulation, it would be better to turn off relevant flags
for safety.  I'm not objecting to the patch, but just wondered.
-- 
Shinya Kuribayashi
Renesas Electronics

Re: [PATCH 3/4] i2c-nomadik: support smbus emulation

[Linus Walleij]

2010/9/24 Shinya Kuribayashi <shinya.kuribayashi.px-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>:
> On 9/23/2010 4:04 PM, Linus Walleij wrote:
>> We can do smbus emulation so flag this and drop the duplicate
>> flags implied from smbus emulation.
>
>> @@ -803,10 +803,7 @@ static irqreturn_t i2c_irq_handler(int irq, void *arg)
>>
>>  static unsigned int nmk_i2c_functionality(struct i2c_adapter *adap)
>>  {
>> -     return I2C_FUNC_I2C
>> -             | I2C_FUNC_SMBUS_BYTE_DATA
>> -             | I2C_FUNC_SMBUS_WORD_DATA
>> -             | I2C_FUNC_SMBUS_I2C_BLOCK;
>> +     return I2C_FUNC_I2C | I2C_FUNC_SMBUS_EMUL;
>>  }
>>
>>  static const struct i2c_algorithm nmk_i2c_algo = {
>
> (failed to figure out from the driver, so would like to make sure)
> Is this I2C core capable of I2C_FUNC_SMBUS_QUICK?  Unless it's capable
> of full SMBus emulation, it would be better to turn off relevant flags
> for safety.  I'm not objecting to the patch, but just wondered.

I have verified with the hardware engineer that this block is indeed
capable of SMBUS_QUICK.

Yours,
Linus Walleij

Re: [PATCH 3/4] i2c-nomadik: support smbus emulation

[Shinya Kuribayashi]

On 9/27/2010 6:00 PM, Linus Walleij wrote:
> 2010/9/24 Shinya Kuribayashi <shinya.kuribayashi.px-zM6kxYcvzFBBDgjK7y7TUQ@public.gmane.org>:
>> On 9/23/2010 4:04 PM, Linus Walleij wrote:
>> Is this I2C core capable of I2C_FUNC_SMBUS_QUICK?  Unless it's capable
>> of full SMBus emulation, it would be better to turn off relevant flags
>> for safety.  I'm not objecting to the patch, but just wondered.
> 
> I have verified with the hardware engineer that this block is indeed
> capable of SMBUS_QUICK.

That's a nice block, no problem.
-- 
Shinya Kuribayashi
Renesas Electronics