From: Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>
To: Praveen Talari <praveen.talari@oss.qualcomm.com>,
Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
Andi Shyti <andi.shyti@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org,
Naresh Maramaina <naresh.maramaina@oss.qualcomm.com>
Subject: Re: [PATCH 0/3] i2c: qcom-geni: improve transfer error recovery and synchronization
Date: Wed, 8 Jul 2026 13:05:03 +0530 [thread overview]
Message-ID: <5cf8bf42-8293-4672-b6b2-226ec1acdb56@oss.qualcomm.com> (raw)
In-Reply-To: <20260708-fix_cancel_sequence_on_failure_for_i2c-v1-0-dd8f841f36a2@oss.qualcomm.com>
On 7/8/2026 11:45 AM, Praveen Talari wrote:
> The GENI I2C driver currently has a few issues in its transfer recovery
has few issues
> and completion handling paths.
>
> The timeout recovery flow directly aborts outstanding commands, while
> GENI hardware requires command cancellation to be attempted before
> issuing an abort. In addition, multiple operations share a common
> completion object, which can allow unrelated events to wake waiters
> prematurely and lead to incorrect synchronization.
>
> Address NACK handling can also trigger unnecessary cancel and reset
cancellation and reset operations
> operations even though the transfer has already terminated during the
> address phase.
>
> Signed-off-by: Praveen Talari <praveen.talari@oss.qualcomm.com>
> ---
> Praveen Talari (3):
> i2c: qcom-geni: use cancel command before abort on transfer timeout
> i2c: qcom-geni: use dedicated completions for abort and reset events
> i2c: qcom-geni: Avoid unnecessary transfer cancel on address NACK
>
> drivers/i2c/busses/i2c-qcom-geni.c | 100 ++++++++++++++++++++++++-------------
> 1 file changed, 66 insertions(+), 34 deletions(-)
> ---
> base-commit: 2b763db0c2763d6bf73d7d3e69665222d1f377cf
> change-id: 20260703-fix_cancel_sequence_on_failure_for_i2c-a868571f77e0
>
> Best regards,
> --
> Praveen Talari <praveen.talari@oss.qualcomm.com>
>
prev parent reply other threads:[~2026-07-08 7:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 6:15 [PATCH 0/3] i2c: qcom-geni: improve transfer error recovery and synchronization Praveen Talari
2026-07-08 6:15 ` [PATCH 1/3] i2c: qcom-geni: use cancel command before abort on transfer timeout Praveen Talari
2026-07-08 7:35 ` Mukesh Savaliya
2026-07-08 9:17 ` Praveen Talari
2026-07-08 6:15 ` [PATCH 2/3] i2c: qcom-geni: use dedicated completions for abort and reset events Praveen Talari
2026-07-08 7:35 ` Mukesh Savaliya
2026-07-08 9:23 ` Praveen Talari
2026-07-08 6:15 ` [PATCH 3/3] i2c: qcom-geni: Avoid unnecessary transfer cancel on address NACK Praveen Talari
2026-07-08 9:41 ` Mukesh Savaliya
2026-07-08 7:35 ` Mukesh Savaliya [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5cf8bf42-8293-4672-b6b2-226ec1acdb56@oss.qualcomm.com \
--to=mukesh.savaliya@oss.qualcomm.com \
--cc=andi.shyti@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naresh.maramaina@oss.qualcomm.com \
--cc=praveen.talari@oss.qualcomm.com \
--cc=viken.dadhaniya@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox