* [PATCH -next] i2c: qcom-geni: Add missing clk_disable_unprepare in geni_i2c_runti @ 2024-08-03 6:10 Gaosheng Cui 2024-08-04 21:21 ` Vladimir Zapolskiy 0 siblings, 1 reply; 4+ messages in thread From: Gaosheng Cui @ 2024-08-03 6:10 UTC (permalink / raw) To: andi.shyti, cuigaosheng1; +Cc: linux-arm-msm, linux-i2c Add the missing clk_disable_unprepare() before return in geni_i2c_runti(). Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> --- drivers/i2c/busses/i2c-qcom-geni.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c index 0a8b95ce35f7..78f43648e9f3 100644 --- a/drivers/i2c/busses/i2c-qcom-geni.c +++ b/drivers/i2c/busses/i2c-qcom-geni.c @@ -990,8 +990,10 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev) return ret; ret = geni_se_resources_on(&gi2c->se); - if (ret) + if (ret) { + clk_disable_unprepare(gi2c->core_clk); return ret; + } enable_irq(gi2c->irq); gi2c->suspended = 0; -- 2.25.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH -next] i2c: qcom-geni: Add missing clk_disable_unprepare in geni_i2c_runti 2024-08-03 6:10 [PATCH -next] i2c: qcom-geni: Add missing clk_disable_unprepare in geni_i2c_runti Gaosheng Cui @ 2024-08-04 21:21 ` Vladimir Zapolskiy 2024-08-05 17:11 ` Andi Shyti 0 siblings, 1 reply; 4+ messages in thread From: Vladimir Zapolskiy @ 2024-08-04 21:21 UTC (permalink / raw) To: Gaosheng Cui, andi.shyti; +Cc: linux-arm-msm, linux-i2c On 8/3/24 09:10, Gaosheng Cui wrote: > Add the missing clk_disable_unprepare() before return in > geni_i2c_runti(). The function name above is scrambled, it should be geni_i2c_runtime_resume(). > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > --- > drivers/i2c/busses/i2c-qcom-geni.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > index 0a8b95ce35f7..78f43648e9f3 100644 > --- a/drivers/i2c/busses/i2c-qcom-geni.c > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > @@ -990,8 +990,10 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev) > return ret; > > ret = geni_se_resources_on(&gi2c->se); > - if (ret) > + if (ret) { > + clk_disable_unprepare(gi2c->core_clk); > return ret; > + } > > enable_irq(gi2c->irq); > gi2c->suspended = 0; The fix is correct, thank you. FWIW there is another missed call of geni_icc_disable(&gi2c->se) on the error paths. Fixes: 14d02fbadb5d ("i2c: qcom-geni: add desc struct to prepare support for I2C Master Hub variant") Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> -- Best wishes, Vladimir ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] i2c: qcom-geni: Add missing clk_disable_unprepare in geni_i2c_runti 2024-08-04 21:21 ` Vladimir Zapolskiy @ 2024-08-05 17:11 ` Andi Shyti 2024-08-06 12:55 ` cuigaosheng 0 siblings, 1 reply; 4+ messages in thread From: Andi Shyti @ 2024-08-05 17:11 UTC (permalink / raw) To: Vladimir Zapolskiy; +Cc: Gaosheng Cui, linux-arm-msm, linux-i2c Hi Gaosheng, On Mon, Aug 05, 2024 at 12:21:53AM GMT, Vladimir Zapolskiy wrote: > On 8/3/24 09:10, Gaosheng Cui wrote: > > Add the missing clk_disable_unprepare() before return in > > geni_i2c_runti(). > > The function name above is scrambled, it should be geni_i2c_runtime_resume(). with the function names fixed, merged into i2c/i2c-host-fixes. > > > > Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> > > --- > > drivers/i2c/busses/i2c-qcom-geni.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c > > index 0a8b95ce35f7..78f43648e9f3 100644 > > --- a/drivers/i2c/busses/i2c-qcom-geni.c > > +++ b/drivers/i2c/busses/i2c-qcom-geni.c > > @@ -990,8 +990,10 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev) > > return ret; > > ret = geni_se_resources_on(&gi2c->se); > > - if (ret) > > + if (ret) { > > + clk_disable_unprepare(gi2c->core_clk); > > return ret; > > + } > > enable_irq(gi2c->irq); > > gi2c->suspended = 0; > > The fix is correct, thank you. > > FWIW there is another missed call of geni_icc_disable(&gi2c->se) on the error paths. Are you going to take care of this, as well? Thanks, Andi > Fixes: 14d02fbadb5d ("i2c: qcom-geni: add desc struct to prepare support for I2C Master Hub variant") > Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> > > -- > Best wishes, > Vladimir ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] i2c: qcom-geni: Add missing clk_disable_unprepare in geni_i2c_runti 2024-08-05 17:11 ` Andi Shyti @ 2024-08-06 12:55 ` cuigaosheng 0 siblings, 0 replies; 4+ messages in thread From: cuigaosheng @ 2024-08-06 12:55 UTC (permalink / raw) To: Andi Shyti, Vladimir Zapolskiy; +Cc: linux-arm-msm, linux-i2c Thanks for your time! > Are you going to take care of this, as well? > > Thanks, > Andi I've made and submitted a patch, thanks again. On 2024/8/6 1:11, Andi Shyti wrote: > Hi Gaosheng, > > On Mon, Aug 05, 2024 at 12:21:53AM GMT, Vladimir Zapolskiy wrote: >> On 8/3/24 09:10, Gaosheng Cui wrote: >>> Add the missing clk_disable_unprepare() before return in >>> geni_i2c_runti(). >> The function name above is scrambled, it should be geni_i2c_runtime_resume(). > with the function names fixed, merged into i2c/i2c-host-fixes. > >>> Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com> >>> --- >>> drivers/i2c/busses/i2c-qcom-geni.c | 4 +++- >>> 1 file changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c >>> index 0a8b95ce35f7..78f43648e9f3 100644 >>> --- a/drivers/i2c/busses/i2c-qcom-geni.c >>> +++ b/drivers/i2c/busses/i2c-qcom-geni.c >>> @@ -990,8 +990,10 @@ static int __maybe_unused geni_i2c_runtime_resume(struct device *dev) >>> return ret; >>> ret = geni_se_resources_on(&gi2c->se); >>> - if (ret) >>> + if (ret) { >>> + clk_disable_unprepare(gi2c->core_clk); >>> return ret; >>> + } >>> enable_irq(gi2c->irq); >>> gi2c->suspended = 0; >> The fix is correct, thank you. >> >> FWIW there is another missed call of geni_icc_disable(&gi2c->se) on the error paths. > Are you going to take care of this, as well? > > Thanks, > Andi > >> Fixes: 14d02fbadb5d ("i2c: qcom-geni: add desc struct to prepare support for I2C Master Hub variant") >> Reviewed-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org> >> >> -- >> Best wishes, >> Vladimir > . ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-08-06 12:55 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2024-08-03 6:10 [PATCH -next] i2c: qcom-geni: Add missing clk_disable_unprepare in geni_i2c_runti Gaosheng Cui 2024-08-04 21:21 ` Vladimir Zapolskiy 2024-08-05 17:11 ` Andi Shyti 2024-08-06 12:55 ` cuigaosheng
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox