Linux I2C development
 help / color / mirror / Atom feed
From: Stefan Wahren <stefan.wahren@i2se.com>
To: Annaliese McDermond <nh6z@nh6z.net>,
	eric@anholt.net, f.fainelli@gmail.com, wsa@the-dreams.de,
	linux-i2c@vger.kernel.org, linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org
Cc: team@nwdigitalradio.com
Subject: Re: [PATCH] i2c: bcm2835: Model Divider in CCF
Date: Sun, 5 May 2019 12:36:29 +0200	[thread overview]
Message-ID: <610c7594-85c9-72db-63a6-6e632e9586aa@i2se.com> (raw)
In-Reply-To: <20190505034339.30778-1-nh6z@nh6z.net>

Hi Annaliese,

Am 05.05.19 um 05:43 schrieb Annaliese McDermond:
> Model the I2C bus clock divider as a part of the Core Clock Framework.
> Primarily this removes the clk_get_rate() call from each transfer.
> This call causes problems for slave drivers that themselves have
> internal clock components that are controlled by an I2C interface.
> When the slave's internal clock component is prepared, the prepare
> lock is obtained, and it makes calls to the I2C subsystem to
> command the hardware to activate the clock.  In order to perform
> the I2C transfer, this driver sets the divider, which requires
> it to get the parent clock rate, which it does with clk_get_rate().
> Unfortunately, this function will try to take the clock prepare
> lock, which is already held by the slave's internal clock calls
> creating a deadlock.

i think i understand the problem, but could you please explain the
specific use case where this happend?

I suspect bcm2835 is not the only platform which is affected, so it
would be better to fix this in general.

Regards

Stefan

  reply	other threads:[~2019-05-05 10:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-05  3:43 [PATCH] i2c: bcm2835: Model Divider in CCF Annaliese McDermond
2019-05-05 10:36 ` Stefan Wahren [this message]
     [not found]   ` <610c7594-85c9-72db-63a6-6e632e9586aa-eS4NqCHxEME@public.gmane.org>
2019-05-05 17:13     ` Florian Fainelli
2019-05-05 17:21       ` Annaliese McDermond
2019-05-06 15:59       ` Nicolas Saenz Julienne
2019-05-05 17:16   ` Annaliese McDermond
2019-05-06 18:14 ` Eric Anholt
2019-05-06 22:56   ` Annaliese McDermond
2019-05-07  4:32     ` Eric Anholt
2019-05-07 13:10       ` Annaliese McDermond
2019-05-07  6:11 ` Stefan Wahren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=610c7594-85c9-72db-63a6-6e632e9586aa@i2se.com \
    --to=stefan.wahren@i2se.com \
    --cc=eric@anholt.net \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nh6z@nh6z.net \
    --cc=team@nwdigitalradio.com \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox