From: Sanford Rockowitz <rockowitz@minsoft.com>
To: Wolfram Sang <wsa@kernel.org>
Cc: linux-i2c@vger.kernel.org
Subject: Re: i2c-dev mismatch with proprietary nvidia driver
Date: Thu, 29 Sep 2022 12:21:11 -0400 [thread overview]
Message-ID: <6335C5F7.40605@minsoft.com> (raw)
In-Reply-To: <YzSdhCrwjPwMr4DI@shikoro>
On 09/28/2022 03:16 PM, Wolfram Sang wrote:
> Hi,
>
>> At approximately line 41 of nvidia driver file nv-i2c.c, in function
>> nv_i2c_algo_master_transfer(), there's an if-test for symbol I2C_M_DMA_SAFE.
>> If the symbol is not defined, a call to the function with the bit set fails
>> with error -EINVAL. The file includes "linux/i2c.h", so apparently there are
>> versions of I2c.h in which the flag is undefined.
> I2C_M_DMA_SAFE is a hint for controller drivers that the buffer is DMA
> capable. It is not something the controller driver needs to support
> actively. Bailing out on this flag is wrong. Do I need to mention that
> such misconceptions are the super-downside of out-of-tree drivers? (I
> know that you are only a user of this driver, so not your fault)
>
> Happy hacking,
>
> Wolfram
>
Hello Wolfram,
Thanks for the clarification. I've included the core of it in my post
on [developer.nvidia.com]
(https://forums.developer.nvidia.com/t/nvidia-driver-i2c-dev-driver-i2c-failure/228966/2)
I'm not holding my breath for a fix any time soon.
I long ago gave up on using Nvidia video cards. Building my own copy of
the nvidia
driver was prone to failure due to mismatches between the kernel and the
driver.
Unfortunately, I can't control the driver that users of ddcutil use.
There's even
a [page on ddcutil's website](https://www.ddcutil.com/nvidia) devoted to
undocumented driver settings that are often needed for I2C.
I had simplified ddcutil's most recent release (1.3.0, which inter alia
will be in
Ubuntu 22.10) to use onlythe i2c-dev's ioctl() interface. The amount of
code
that had to go back in was both extensive and painful.
Regards,
Sanford
prev parent reply other threads:[~2022-09-29 16:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 1:12 i2c-dev mismatch with proprietary nvidia driver Sanford Rockowitz
2022-09-28 19:16 ` Wolfram Sang
2022-09-29 16:21 ` Sanford Rockowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6335C5F7.40605@minsoft.com \
--to=rockowitz@minsoft.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox