From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Robert Foss <rfoss@kernel.org>,
Loic Poulain <loic.poulain@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Wolfram Sang <wsa@kernel.org>
Cc: Neil Armstrong <neil.armstrong@linaro.org>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH] Revert "Revert "dt-bindings: i2c: qcom-cci: Document sc8280xp compatible""
Date: Thu, 11 Apr 2024 13:21:30 +0100 [thread overview]
Message-ID: <7098c454-6a1d-46ae-aef9-63bb9ee82c6a@linaro.org> (raw)
In-Reply-To: <0b810e39-b82f-4cca-87b0-6e586690b242@linaro.org>
On 11/04/2024 13:03, Krzysztof Kozlowski wrote:
> On 11/04/2024 10:52, Vladimir Zapolskiy wrote:
>> This reverts commit 3e383dce513f426b7d79c0e6f8afe5d22a581f58.
>>
>> The commit ae2a1f0f2cb5 ("dt-bindings: i2c: qcom-cci: Document sc8280xp compatible")
>> was correct apparently, it is required to describe the sc8280xp-cci
>> controller properly, as well it eliminates dtbs_check warnings.
>>
>> Signed-off-by: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>
>
> Subject:
> dt-bindings: i2c: Revert ....
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
> Best regards,
> Krzysztof
Reversion is not the right fix.
I'll send a proper fix asap.
cci0: cci@ac4a000 {
compatible = "qcom,sc8280xp-cci", "qcom,msm8996-cci";
clock-names = "camnoc_axi",
"slow_ahb_src",
"cpas_ahb",
"cci";
- if:
properties:
compatible:
contains:
enum:
- qcom,sc7280-cci
- qcom,sc8280xp-cci-no-bueno
- qcom,sm8250-cci
- qcom,sm8450-cci
then:
properties:
clocks:
minItems: 5
maxItems: 5
clock-names:
items:
- const: camnoc_axi
- const: slow_ahb_src
- const: cpas_ahb
- const: cci
- const: cci_src
---
bod
next prev parent reply other threads:[~2024-04-11 12:21 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 8:52 [PATCH] Revert "Revert "dt-bindings: i2c: qcom-cci: Document sc8280xp compatible"" Vladimir Zapolskiy
2024-04-11 9:36 ` Krzysztof Kozlowski
2024-04-11 10:12 ` Bryan O'Donoghue
2024-04-11 10:16 ` Krzysztof Kozlowski
2024-04-11 10:18 ` Krzysztof Kozlowski
2024-04-11 10:24 ` Bryan O'Donoghue
2024-04-11 10:28 ` Krzysztof Kozlowski
2024-04-11 11:57 ` Bryan O'Donoghue
2024-04-11 12:01 ` Bryan O'Donoghue
2024-04-11 12:02 ` Krzysztof Kozlowski
2024-04-11 12:03 ` Krzysztof Kozlowski
2024-04-11 12:21 ` Bryan O'Donoghue [this message]
2024-04-11 12:36 ` Krzysztof Kozlowski
2024-04-11 13:20 ` Vladimir Zapolskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7098c454-6a1d-46ae-aef9-63bb9ee82c6a@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox