* [PATCH] drm/amd/pm: Remove I2C_CLASS_SPD support
@ 2023-11-13 11:37 Heiner Kallweit
2023-11-13 11:42 ` Heiner Kallweit
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Heiner Kallweit @ 2023-11-13 11:37 UTC (permalink / raw)
To: Evan Quan, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Wolfram Sang
Cc: open list:RADEON and AMDGPU DRM DRIVERS, open list:AMD KFD,
linux-i2c@vger.kernel.org
I2C_CLASS_SPD was used to expose the EEPROM content to user space,
via the legacy eeprom driver. Now that this driver has been removed,
we can remove I2C_CLASS_SPD support. at24 driver with explicit
instantiation should be used instead.
If in doubt this patch could be applied via the i2c tree.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 1 -
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 1 -
drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
index 1a6675d70..bc56a29e6 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
@@ -1527,7 +1527,6 @@ static int aldebaran_i2c_control_init(struct smu_context *smu)
smu_i2c->port = 0;
mutex_init(&smu_i2c->mutex);
control->owner = THIS_MODULE;
- control->class = I2C_CLASS_SPD;
control->dev.parent = &adev->pdev->dev;
control->algo = &aldebaran_i2c_algo;
snprintf(control->name, sizeof(control->name), "AMDGPU SMU 0");
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
index 82c4e1f1c..c0e62bab9 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
@@ -2720,7 +2720,6 @@ static int smu_v13_0_0_i2c_control_init(struct smu_context *smu)
smu_i2c->port = i;
mutex_init(&smu_i2c->mutex);
control->owner = THIS_MODULE;
- control->class = I2C_CLASS_SPD;
control->dev.parent = &adev->pdev->dev;
control->algo = &smu_v13_0_0_i2c_algo;
snprintf(control->name, sizeof(control->name), "AMDGPU SMU %d", i);
diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
index 891605d49..9de91bd77 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
@@ -1884,7 +1884,6 @@ static int smu_v13_0_6_i2c_control_init(struct smu_context *smu)
smu_i2c->port = i;
mutex_init(&smu_i2c->mutex);
control->owner = THIS_MODULE;
- control->class = I2C_CLASS_SPD;
control->dev.parent = &adev->pdev->dev;
control->algo = &smu_v13_0_6_i2c_algo;
snprintf(control->name, sizeof(control->name), "AMDGPU SMU %d", i);
--
2.42.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/amd/pm: Remove I2C_CLASS_SPD support
2023-11-13 11:37 [PATCH] drm/amd/pm: Remove I2C_CLASS_SPD support Heiner Kallweit
@ 2023-11-13 11:42 ` Heiner Kallweit
2023-11-16 19:15 ` Alex Deucher
2023-12-19 12:21 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Heiner Kallweit @ 2023-11-13 11:42 UTC (permalink / raw)
To: Alex Deucher, Christian König, Pan, Xinhui, David Airlie,
Daniel Vetter, Wolfram Sang
Cc: open list:RADEON and AMDGPU DRM DRIVERS, open list:AMD KFD,
linux-i2c@vger.kernel.org
On 13.11.2023 12:37, Heiner Kallweit wrote:
> I2C_CLASS_SPD was used to expose the EEPROM content to user space,
> via the legacy eeprom driver. Now that this driver has been removed,
> we can remove I2C_CLASS_SPD support. at24 driver with explicit
> instantiation should be used instead.
>
> If in doubt this patch could be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
The mail to Evan couldn't be delivered. Maybe MAINTAINERS needs to be updated?
Generating server: SATLEXMB03.amd.com
evan.quan@amd.com
Remote Server returned '550 5.1.10 RESOLVER.ADR.RecipientNotFound; Recipient not found by SMTP address lookup'
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/pm: Remove I2C_CLASS_SPD support
2023-11-13 11:37 [PATCH] drm/amd/pm: Remove I2C_CLASS_SPD support Heiner Kallweit
2023-11-13 11:42 ` Heiner Kallweit
@ 2023-11-16 19:15 ` Alex Deucher
2023-12-19 12:21 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2023-11-16 19:15 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Evan Quan, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter, Wolfram Sang, open list:AMD KFD,
open list:RADEON and AMDGPU DRM DRIVERS,
linux-i2c@vger.kernel.org
On Mon, Nov 13, 2023 at 6:37 AM Heiner Kallweit <hkallweit1@gmail.com> wrote:
>
> I2C_CLASS_SPD was used to expose the EEPROM content to user space,
> via the legacy eeprom driver. Now that this driver has been removed,
> we can remove I2C_CLASS_SPD support. at24 driver with explicit
> instantiation should be used instead.
>
> If in doubt this patch could be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
Feel free to take this via the i2c tree if you prefer.
Alex
> ---
> drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 1 -
> drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c | 1 -
> drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> index 1a6675d70..bc56a29e6 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> @@ -1527,7 +1527,6 @@ static int aldebaran_i2c_control_init(struct smu_context *smu)
> smu_i2c->port = 0;
> mutex_init(&smu_i2c->mutex);
> control->owner = THIS_MODULE;
> - control->class = I2C_CLASS_SPD;
> control->dev.parent = &adev->pdev->dev;
> control->algo = &aldebaran_i2c_algo;
> snprintf(control->name, sizeof(control->name), "AMDGPU SMU 0");
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> index 82c4e1f1c..c0e62bab9 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_0_ppt.c
> @@ -2720,7 +2720,6 @@ static int smu_v13_0_0_i2c_control_init(struct smu_context *smu)
> smu_i2c->port = i;
> mutex_init(&smu_i2c->mutex);
> control->owner = THIS_MODULE;
> - control->class = I2C_CLASS_SPD;
> control->dev.parent = &adev->pdev->dev;
> control->algo = &smu_v13_0_0_i2c_algo;
> snprintf(control->name, sizeof(control->name), "AMDGPU SMU %d", i);
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> index 891605d49..9de91bd77 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/smu_v13_0_6_ppt.c
> @@ -1884,7 +1884,6 @@ static int smu_v13_0_6_i2c_control_init(struct smu_context *smu)
> smu_i2c->port = i;
> mutex_init(&smu_i2c->mutex);
> control->owner = THIS_MODULE;
> - control->class = I2C_CLASS_SPD;
> control->dev.parent = &adev->pdev->dev;
> control->algo = &smu_v13_0_6_i2c_algo;
> snprintf(control->name, sizeof(control->name), "AMDGPU SMU %d", i);
> --
> 2.42.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/amd/pm: Remove I2C_CLASS_SPD support
2023-11-13 11:37 [PATCH] drm/amd/pm: Remove I2C_CLASS_SPD support Heiner Kallweit
2023-11-13 11:42 ` Heiner Kallweit
2023-11-16 19:15 ` Alex Deucher
@ 2023-12-19 12:21 ` Wolfram Sang
2 siblings, 0 replies; 4+ messages in thread
From: Wolfram Sang @ 2023-12-19 12:21 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Evan Quan, Alex Deucher, Christian König, Pan, Xinhui,
David Airlie, Daniel Vetter,
open list:RADEON and AMDGPU DRM DRIVERS, open list:AMD KFD,
linux-i2c@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 475 bytes --]
On Mon, Nov 13, 2023 at 12:37:15PM +0100, Heiner Kallweit wrote:
> I2C_CLASS_SPD was used to expose the EEPROM content to user space,
> via the legacy eeprom driver. Now that this driver has been removed,
> we can remove I2C_CLASS_SPD support. at24 driver with explicit
> instantiation should be used instead.
>
> If in doubt this patch could be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-12-19 12:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-11-13 11:37 [PATCH] drm/amd/pm: Remove I2C_CLASS_SPD support Heiner Kallweit
2023-11-13 11:42 ` Heiner Kallweit
2023-11-16 19:15 ` Alex Deucher
2023-12-19 12:21 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox