From: Yang Yingliang <yangyingliang@huawei.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: <linux-i2c@vger.kernel.org>,
Yicong Yang <yangyicong@hisilicon.com>,
Dmitry Osipenko <digetx@gmail.com>, Wolfram Sang <wsa@kernel.org>,
"Jonathan Corbet" <corbet@lwn.net>, <yangyingliang@huawei.com>
Subject: Re: [PATCH] Documentation: devres: add missing I2C helper
Date: Wed, 2 Nov 2022 21:22:58 +0800 [thread overview]
Message-ID: <83ce64b4-1ece-64eb-eedd-b0e5ba06ac46@huawei.com> (raw)
In-Reply-To: <Y2JIpwqDinm5N1T2@smile.fi.intel.com>
On 2022/11/2 18:38, Andy Shevchenko wrote:
> On Wed, Nov 02, 2022 at 11:40:53AM +0800, Yang Yingliang wrote:
>> Add missing devm_i2c_add_adapter() to devres.rst. It's introduced by
>> commit 07740c92ae57 ("i2c: core: add managed function for adding i2c
>> adapters").
> Okay,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
>> Fixes: 07740c92ae57 ("i2c: core: add managed function for adding i2c adapters")
>> Cc: Yicong Yang <yangyicong@hisilicon.com>
>> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Cc: Dmitry Osipenko <digetx@gmail.com>
>> Cc: Wolfram Sang <wsa@kernel.org>
>> Cc: Jonathan Corbet <corbet@lwn.net>
> Next time, please use --cc when sending patches, instead of Cc'ing explicitly
> in the body of the message. The rationale is that we have this email in the
> archives anyway and every additional byte in the commit message is a waste of
> resources (storage, energy and as a result not so environment friendly).
OK, thanks for your advice.
>
>> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>> ---
>> Documentation/driver-api/driver-model/devres.rst | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
>> index 853396d19419..ec97261530da 100644
>> --- a/Documentation/driver-api/driver-model/devres.rst
>> +++ b/Documentation/driver-api/driver-model/devres.rst
>> @@ -280,6 +280,7 @@ GPIO
>>
>> I2C
>> devm_i2c_new_dummy_device()
>> + devm_i2c_add_adapter()
> Perhaps keep this list ordered?
OK, I will send a v2 to change it with your review tag.
Thanks,
Yang
>
prev parent reply other threads:[~2022-11-02 13:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 3:40 [PATCH] Documentation: devres: add missing I2C helper Yang Yingliang
2022-11-02 7:29 ` Yicong Yang
2022-11-02 10:38 ` Andy Shevchenko
2022-11-02 13:22 ` Yang Yingliang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ce64b4-1ece-64eb-eedd-b0e5ba06ac46@huawei.com \
--to=yangyingliang@huawei.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=corbet@lwn.net \
--cc=digetx@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@kernel.org \
--cc=yangyicong@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox