public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-i2c@vger.kernel.org, Yicong Yang <yangyicong@hisilicon.com>,
	Dmitry Osipenko <digetx@gmail.com>, Wolfram Sang <wsa@kernel.org>,
	Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH] Documentation: devres: add missing I2C helper
Date: Wed, 2 Nov 2022 12:38:31 +0200	[thread overview]
Message-ID: <Y2JIpwqDinm5N1T2@smile.fi.intel.com> (raw)
In-Reply-To: <20221102034053.1708845-1-yangyingliang@huawei.com>

On Wed, Nov 02, 2022 at 11:40:53AM +0800, Yang Yingliang wrote:
> Add missing devm_i2c_add_adapter() to devres.rst. It's introduced by
> commit 07740c92ae57 ("i2c: core: add managed function for adding i2c
> adapters").

Okay,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

> Fixes: 07740c92ae57 ("i2c: core: add managed function for adding i2c adapters")
> Cc: Yicong Yang <yangyicong@hisilicon.com>
> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: Dmitry Osipenko <digetx@gmail.com>
> Cc: Wolfram Sang <wsa@kernel.org>
> Cc: Jonathan Corbet <corbet@lwn.net>

Next time, please use --cc when sending patches, instead of Cc'ing explicitly
in the body of the message. The rationale is that we have this email in the
archives anyway and every additional byte in the commit message is a waste of
resources (storage, energy and as a result not so environment friendly).

> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
>  Documentation/driver-api/driver-model/devres.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
> index 853396d19419..ec97261530da 100644
> --- a/Documentation/driver-api/driver-model/devres.rst
> +++ b/Documentation/driver-api/driver-model/devres.rst
> @@ -280,6 +280,7 @@ GPIO
>  
>  I2C
>    devm_i2c_new_dummy_device()
> +  devm_i2c_add_adapter()

Perhaps keep this list ordered?

-- 
With Best Regards,
Andy Shevchenko



  parent reply	other threads:[~2022-11-02 10:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-02  3:40 [PATCH] Documentation: devres: add missing I2C helper Yang Yingliang
2022-11-02  7:29 ` Yicong Yang
2022-11-02 10:38 ` Andy Shevchenko [this message]
2022-11-02 13:22   ` Yang Yingliang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y2JIpwqDinm5N1T2@smile.fi.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=digetx@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=wsa@kernel.org \
    --cc=yangyicong@hisilicon.com \
    --cc=yangyingliang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox