From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
Cc: Loic Poulain <loic.poulain@oss.qualcomm.com>,
Robert Foss <rfoss@kernel.org>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Todor Tomov <todor.too@gmail.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com,
tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com,
yijie.yang@oss.qualcomm.com,
Jingyi Wang <jingyi.wang@oss.qualcomm.com>,
Atiya Kailany <atiya.kailany@oss.qualcomm.com>
Subject: Re: [PATCH v3 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding
Date: Tue, 28 Oct 2025 09:10:39 +0100 [thread overview]
Message-ID: <84ae4280-d0f0-42a2-acfd-e85e0263be1d@kernel.org> (raw)
In-Reply-To: <20251028-wonderful-olive-muskox-77f98d@kuoka>
On 28/10/2025 09:09, Krzysztof Kozlowski wrote:
> On Thu, Oct 23, 2025 at 02:14:34AM -0700, Hangxiang Ma wrote:
>> Add bindings for qcom,kaanapali-camss in order to support the camera
>
> What is qcom,kaanapali-camss? Sounds like a compatible and you cannot
> add bindings for a compatible. Instead add bindings for hardware, so
> explain here hardware.
>
> You could easily use `git log` to see how such commits are written
> instead of pasting here your downstream practice.
>
And of course standard comment:
A nit, subject: drop second/last, redundant "binding". The "dt-bindings"
prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v6.17-rc3/source/Documentation/devicetree/bindings/submitting-patches.rst#L18
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-10-28 8:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 9:14 [PATCH v3 0/6] media: qcom: camss: Add Kaanapali support Hangxiang Ma
2025-10-23 9:14 ` [PATCH v3 1/6] dt-bindings: i2c: qcom-cci: Document Kaanapali compatible Hangxiang Ma
2025-10-23 15:24 ` Krzysztof Kozlowski
2025-10-24 9:04 ` Loic Poulain
2025-10-23 9:14 ` [PATCH v3 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding Hangxiang Ma
2025-10-28 8:09 ` Krzysztof Kozlowski
2025-10-28 8:10 ` Krzysztof Kozlowski [this message]
2025-10-29 5:42 ` Hangxiang Ma
2025-10-28 15:22 ` Vijay Kumar Tumati
2025-10-28 16:56 ` Krzysztof Kozlowski
2025-10-28 17:45 ` Vijay Kumar Tumati
2025-10-28 18:39 ` Krzysztof Kozlowski
2025-10-28 19:18 ` Vijay Kumar Tumati
2025-10-23 9:14 ` [PATCH v3 3/6] media: qcom: camss: Add Kaanapali compatible camss driver Hangxiang Ma
2025-10-23 9:14 ` [PATCH v3 4/6] media: qcom: camss: csiphy: Add support for v2.4.0 two-phase CSIPHY Hangxiang Ma
2025-10-23 9:14 ` [PATCH v3 5/6] media: qcom: camss: csid: Add support for CSID 1080 Hangxiang Ma
2025-10-23 9:14 ` [PATCH v3 6/6] media: qcom: camss: vfe: Add support for VFE 1080 Hangxiang Ma
2025-10-28 9:34 ` [PATCH v3 0/6] media: qcom: camss: Add Kaanapali support Bryan O'Donoghue
2025-10-28 14:37 ` Vijay Kumar Tumati
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84ae4280-d0f0-42a2-acfd-e85e0263be1d@kernel.org \
--to=krzk@kernel.org \
--cc=aiqun.yu@oss.qualcomm.com \
--cc=andi.shyti@kernel.org \
--cc=atiya.kailany@oss.qualcomm.com \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hangxiang.ma@oss.qualcomm.com \
--cc=jingyi.wang@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=tingwei.zhang@oss.qualcomm.com \
--cc=todor.too@gmail.com \
--cc=trilok.soni@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
--cc=yijie.yang@oss.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox