public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: <konrad.dybcio@linaro.org>, <andersson@kernel.org>,
	<linux-arm-msm@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-i2c@vger.kernel.org>, <quic_vdadhani@quicinc.com>,
	<vkoul@kernel.org>
Subject: Re: [PATCH] i2c: i2c-qcom-geni: Serve transfer during early resume stage
Date: Fri, 27 Sep 2024 17:49:17 +0530	[thread overview]
Message-ID: <85b156c8-aef5-4080-bc4d-e1bb8a4f0977@quicinc.com> (raw)
In-Reply-To: <uib7it3noxnkekza4p4ngf5w677fizrb7j5ov7ekos2vinge5x@sh24m63gmkrr>

Hi Andi, sorry. Yes this is active. let me push V2 addressing comments 
for V1. i was completely away earlier hence restarting now.

On 9/12/2024 3:32 PM, Andi Shyti wrote:
> Hi Mukesh,
> 
> Is this patch still needed? Can anyone active in the Qualcomm
> drivers take a look?
> 
> On Tue, Apr 02, 2024 at 03:57:41PM GMT, Mukesh Kumar Savaliya wrote:
>> pm_runtime_get_sync() function fails during PM early resume and returning
>> -EACCES because runtime PM for the device is disabled at the early stage
>> causing i2c transfer to fail. Make changes to serve transfer with force
>> resume.
>>
>> 1. Register interrupt with IRQF_EARLY_RESUME and IRQF_NO_SUSPEND flags
>>     to avoid timeout of transfer when IRQ is not enabled during early stage.
>> 2. Do force resume if pm_runtime_get_sync() is failing after system
>>     suspend when runtime PM is not enabled.
>> 3. Increment power usage count after forced resume to balance
>>     it against regular runtime suspend.
>>
>> Co-developed-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
>> Signed-off-by: Viken Dadhaniya <quic_vdadhani@quicinc.com>
>> Signed-off-by: Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
> 
> Should this be considered a fix?
> 
> Thanks,
> Andi

  reply	other threads:[~2024-09-27 12:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-02 10:27 [PATCH] i2c: i2c-qcom-geni: Serve transfer during early resume stage Mukesh Kumar Savaliya
2024-09-12 10:02 ` Andi Shyti
2024-09-27 12:19   ` Mukesh Kumar Savaliya [this message]
2024-09-13  2:54 ` Bjorn Andersson
2024-09-27 12:32   ` Mukesh Kumar Savaliya

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85b156c8-aef5-4080-bc4d-e1bb8a4f0977@quicinc.com \
    --to=quic_msavaliy@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_vdadhani@quicinc.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox