10-bit address support in i2c-omap and i2c-davinci

10-bit address support in i2c-omap and i2c-davinci

[Jean Delvare]

Both bus drivers i2c-omap and i2c-davinci apparently handle 10-bit addresses:

(i2c-omap.c)
	if (msg->flags & I2C_M_TEN)
		w |= OMAP_I2C_CON_XA;

(i2c-davinci.c)
	/* if the slave address is ten bit address, enable XA bit */
	if (msg->flags & I2C_M_TEN)
		flag |= DAVINCI_I2C_MDR_XA;

However neither driver declares functionality flag I2C_FUNC_10BIT_ADDR,
so chip drivers would normally refuse to bind to these buses. If 10-bit
address support is incomplete or broken then it should be removed
completely. If it works then these drivers should declare so by adding
I2C_FUNC_10BIT_ADDR to the functionality flags they return.

-- 
Jean Delvare

Re: 10-bit address support in i2c-omap and i2c-davinci

[Kevin Hilman]

Adding linux-omap and linux-davinci lists

Jean Delvare <khali@linux-fr.org> writes:

> Both bus drivers i2c-omap and i2c-davinci apparently handle 10-bit addresses:
>
> (i2c-omap.c)
> 	if (msg->flags & I2C_M_TEN)
> 		w |= OMAP_I2C_CON_XA;
>
> (i2c-davinci.c)
> 	/* if the slave address is ten bit address, enable XA bit */
> 	if (msg->flags & I2C_M_TEN)
> 		flag |= DAVINCI_I2C_MDR_XA;
>
> However neither driver declares functionality flag I2C_FUNC_10BIT_ADDR,
> so chip drivers would normally refuse to bind to these buses. If 10-bit
> address support is incomplete or broken then it should be removed
> completely. If it works then these drivers should declare so by adding
> I2C_FUNC_10BIT_ADDR to the functionality flags they return.

Re: 10-bit address support in i2c-omap and i2c-davinci

[Jean Delvare]

On Mon, 07 Nov 2011 07:09:38 -0800, Kevin Hilman wrote:
> Adding linux-omap and linux-davinci lists

Good point, sorry for missing that. Maybe the following would help?

List i2c-omap and i2c-davinci in MAINTAINERS.

Signed-off-by: Jean Delvare <khali@linux-fr.org>
---
 MAINTAINERS |    3 +++
 1 file changed, 3 insertions(+)

--- linux-3.2-rc0.orig/MAINTAINERS	2011-11-07 17:55:46.000000000 +0100
+++ linux-3.2-rc0/MAINTAINERS	2011-11-07 17:55:55.000000000 +0100
@@ -4675,6 +4675,8 @@ Q:	http://patchwork.kernel.org/project/l
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/tmlind/linux-omap-2.6.git
 S:	Maintained
 F:	arch/arm/*omap*/
+F:	drivers/i2c/busses/i2c-omap.c
+F:	include/linux/i2c-omap.h
 
 OMAP CLOCK FRAMEWORK SUPPORT
 M:	Paul Walmsley <paul@pwsan.com>
@@ -5940,6 +5942,7 @@ L:	davinci-linux-open-source@linux.davin
 Q:	http://patchwork.kernel.org/project/linux-davinci/list/
 S:	Supported
 F:	arch/arm/mach-davinci
+F:	drivers/i2c/busses/i2c-davinci.c
 
 SIS 190 ETHERNET DRIVER
 M:	Francois Romieu <romieu@fr.zoreil.com>


-- 
Jean Delvare