From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Wolfram Sang <wsa@kernel.org>, Chris Morgan <macroalpha82@gmail.com>
Cc: linux-i2c@vger.kernel.org, Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH] i2c: mv64xxx: Remove shutdown method from driver
Date: Wed, 25 May 2022 15:42:30 +0200 [thread overview]
Message-ID: <87pmk1ybi1.fsf@BL-laptop> (raw)
In-Reply-To: <YoiGLxhfgYxLURyt@shikoro>
Wolfram Sang <wsa@kernel.org> writes:
> On Fri, Mar 25, 2022 at 01:06:25PM -0500, Chris Morgan wrote:
>> From: Chris Morgan <macromorgan@hotmail.com>
>>
>> When I attempt to shut down (or reboot) my R8 based NTC CHIP with this
>> i2c driver I get the following error: "i2c i2c-0: mv64xxx: I2C bus
>> locked, block: 1, time_left: 0". Reboots are successful but shutdowns
>> freeze. If I comment out the shutdown routine the device both reboots
>> and shuts down successfully without receiving this error (however it
>> does receive a warning of missing atomic_xfer).
>>
>> It appears that very few i2c drivers have a shutdown method, I assume
>> because these devices are often used to communicate with PMICs (such
>> as in my case with the R8 based NTC CHIP). I'm proposing we simply
>> remove this method so long as it doesn't cause trouble for others
>> downstream. I'll work on an atomic_xfer method and submit that in
>> a different patch.
>>
>> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
>
> Gregory? Looks reasonable to me.
Acked-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Thanks,
Gregory
--
Gregory Clement, Bootlin
Embedded Linux and Kernel engineering
http://bootlin.com
prev parent reply other threads:[~2022-05-25 13:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 18:06 [PATCH] i2c: mv64xxx: Remove shutdown method from driver Chris Morgan
2022-05-21 6:26 ` Wolfram Sang
2022-05-25 13:42 ` Gregory CLEMENT [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pmk1ybi1.fsf@BL-laptop \
--to=gregory.clement@bootlin.com \
--cc=linux-i2c@vger.kernel.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox