From: Wolfram Sang <wsa@kernel.org>
To: Chris Morgan <macroalpha82@gmail.com>
Cc: linux-i2c@vger.kernel.org, gregory.clement@bootlin.com,
Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH] i2c: mv64xxx: Remove shutdown method from driver
Date: Sat, 21 May 2022 08:26:55 +0200 [thread overview]
Message-ID: <YoiGLxhfgYxLURyt@shikoro> (raw)
In-Reply-To: <20220325180625.31414-1-macroalpha82@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1006 bytes --]
On Fri, Mar 25, 2022 at 01:06:25PM -0500, Chris Morgan wrote:
> From: Chris Morgan <macromorgan@hotmail.com>
>
> When I attempt to shut down (or reboot) my R8 based NTC CHIP with this
> i2c driver I get the following error: "i2c i2c-0: mv64xxx: I2C bus
> locked, block: 1, time_left: 0". Reboots are successful but shutdowns
> freeze. If I comment out the shutdown routine the device both reboots
> and shuts down successfully without receiving this error (however it
> does receive a warning of missing atomic_xfer).
>
> It appears that very few i2c drivers have a shutdown method, I assume
> because these devices are often used to communicate with PMICs (such
> as in my case with the R8 based NTC CHIP). I'm proposing we simply
> remove this method so long as it doesn't cause trouble for others
> downstream. I'll work on an atomic_xfer method and submit that in
> a different patch.
>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Gregory? Looks reasonable to me.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-05-21 6:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 18:06 [PATCH] i2c: mv64xxx: Remove shutdown method from driver Chris Morgan
2022-05-21 6:26 ` Wolfram Sang [this message]
2022-05-25 13:42 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YoiGLxhfgYxLURyt@shikoro \
--to=wsa@kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=linux-i2c@vger.kernel.org \
--cc=macroalpha82@gmail.com \
--cc=macromorgan@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox