Linux I2C development
 help / color / mirror / Atom feed
From: Aniket RANDIVE <aniket.randive@oss.qualcomm.com>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: Mukesh Savaliya <mukesh.savaliya@oss.qualcomm.com>,
	Andi Shyti <andi.shyti@kernel.org>,
	Viken Dadhaniya <viken.dadhaniya@oss.qualcomm.com>,
	linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, Wolfram Sang <wsa@kernel.org>
Subject: Re: [PATCH v6 1/2] i2c: core: Add i2c_update_timeout() helper for dynamic transfer timeouts
Date: Mon, 3 Aug 2026 16:23:45 +0530	[thread overview]
Message-ID: <8a7fa505-1102-49d8-9343-0fce37850b48@oss.qualcomm.com> (raw)
In-Reply-To: <am5e6yBm-4ZH1W27@shikoro>

Hi Wolfram,

Thanks for the suggestion.

I'm okay with the Kconfig-based approach, as it would avoid regressions 
for platforms that prefer the existing static 1 Hz timeout behavior 
while allowing controllers that benefit from dynamic timeout calculation 
to opt in.

I have reviewed the patch series in [1], and my understanding is that it 
does not directly conflict with the dynamic timeout changes. My series 
calculates transfer timeouts based on the configured bus frequency, 
while the referenced work focuses on dynamically changing bus speeds. At 
the moment, I don't see any functional overlap that would require the 
timeout series to be based on top of it.

That said, please let me know if I'm missing any relationship between 
the two series that should be considered before posting the next revision.

Thanks,
Aniket

On 8/2/2026 2:32 AM, Wolfram Sang wrote:
> On Thu, Jul 30, 2026 at 10:23:46PM +0200, Wolfram Sang wrote:
>>
>>> Given the feedback so far, would maintainers prefer that if i drop the core
>>> helper entirely and keep the dynamic timeout calculation local to the
>>> qcom-geni driver or should we continue exploring an opt-in core-based
>>> approach?
>>
>> Well, I suggested a potential way in my last mail (Kconfig option). So,
>> what do you think about it? Does it handle your use case?
> 
> Another bit which may be important for you: there is currently a patch
> set under discussion [1] to allow changing bus speeds dynamically. You
> probably want to base your work on top of it and/or help getting it
> discussed?
> 
> Happy hacking!
> 
> [1] https://lore.kernel.org/all/20260719-i2c-mux-v12-0-a5010d623a57@gmail.com/
> 
> 

  reply	other threads:[~2026-08-03 10:53 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-20 11:41 [PATCH v6 0/2] i2c: Add dynamic transfer timeout based on message length and frequency Aniket Randive
2026-07-20 11:41 ` [PATCH v6 1/2] i2c: core: Add i2c_update_timeout() helper for dynamic transfer timeouts Aniket Randive
2026-07-22  5:25   ` Mukesh Savaliya
2026-07-24 11:46     ` Aniket RANDIVE
2026-07-26 20:11   ` Andi Shyti
2026-07-27  4:15     ` Mukesh Savaliya
2026-07-27 20:42       ` Andi Shyti
2026-07-28  4:56         ` Mukesh Savaliya
2026-07-28  9:42           ` Wolfram Sang
2026-07-28 10:14             ` Mukesh Savaliya
2026-07-29 15:19               ` Wolfram Sang
2026-07-30 11:53                 ` Aniket RANDIVE
2026-07-30 20:23                   ` Wolfram Sang
2026-08-01 21:02                     ` Wolfram Sang
2026-08-03 10:53                       ` Aniket RANDIVE [this message]
2026-08-03 11:52                 ` Mukesh Savaliya
2026-07-20 11:41 ` [PATCH v6 2/2] i2c: qcom-geni: Add dynamic transfer timeout based on transfer length and frequency Aniket Randive
2026-07-22  5:26   ` Mukesh Savaliya
2026-07-24 11:51     ` Aniket RANDIVE
2026-07-22  5:25 ` [PATCH v6 0/2] i2c: Add dynamic transfer timeout based on message " Mukesh Savaliya
2026-07-24 11:56   ` Aniket RANDIVE

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8a7fa505-1102-49d8-9343-0fce37850b48@oss.qualcomm.com \
    --to=aniket.randive@oss.qualcomm.com \
    --cc=andi.shyti@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mukesh.savaliya@oss.qualcomm.com \
    --cc=viken.dadhaniya@oss.qualcomm.com \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=wsa@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox