From: Krzysztof Kozlowski <krzk@kernel.org>
To: Viken Dadhaniya <quic_vdadhani@quicinc.com>,
andi.shyti@kernel.org, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, gregkh@linuxfoundation.org,
jirislaby@kernel.org, broonie@kernel.or, andersson@kernel.org,
konradybcio@kernel.org, johan+linaro@kernel.org,
dianders@chromium.org, agross@kernel.org,
linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-serial@vger.kernel.org, linux-spi@vger.kernel.org
Cc: quic_anupkulk@quicinc.com,
Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>
Subject: Re: [PATCH v1 1/7] dt-bindings: i2c: qcom,i2c-geni: Document DT properties for QUP firmware loading
Date: Tue, 10 Dec 2024 08:23:42 +0100 [thread overview]
Message-ID: <9df703d9-b2c3-4978-9325-7ad50087e8f1@kernel.org> (raw)
In-Reply-To: <2d615fdb-a661-4fb5-bde7-46f4690ecdce@quicinc.com>
On 10/12/2024 05:43, Viken Dadhaniya wrote:
>>> maxItems: 1
>>>
>>> + qcom,load-firmware:
>>> + type: boolean
>>> + description: Optional property to load SE (serial engine) Firmware from protocol driver.
>>
>>
>> Please wrap code according to coding style (checkpatch is not a coding
>> style description, but only a tool).
> Actually i have ran dt-schema for yaml validation. I couldn't get if you
> have any comment for description statement OR it's related to code ?
> Could you please be more descriptive so i can adopt the suggestions.
This code is not conforming to coding style in terms of wrapping, what
dtschema has to do with it? Please read coding style.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-12-10 7:23 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 15:03 [PATCH v1 0/7] Add support to load QUP SE firmware from Viken Dadhaniya
2024-12-04 15:03 ` [PATCH v1 1/7] dt-bindings: i2c: qcom,i2c-geni: Document DT properties for QUP firmware loading Viken Dadhaniya
2024-12-04 15:06 ` Krzysztof Kozlowski
2024-12-10 4:43 ` Viken Dadhaniya
2024-12-10 7:23 ` Krzysztof Kozlowski [this message]
2024-12-04 15:25 ` neil.armstrong
2024-12-10 4:44 ` Viken Dadhaniya
2024-12-04 17:25 ` Doug Anderson
2024-12-10 5:28 ` Viken Dadhaniya
2024-12-10 17:42 ` Doug Anderson
2024-12-11 5:27 ` Viken Dadhaniya
2024-12-11 22:27 ` Doug Anderson
2024-12-04 22:36 ` Dmitry Baryshkov
2024-12-10 4:48 ` Viken Dadhaniya
2024-12-04 15:03 ` [PATCH v1 2/7] spi: dt-bindings: " Viken Dadhaniya
2024-12-04 15:07 ` Krzysztof Kozlowski
2024-12-04 15:03 ` [PATCH v1 3/7] dt-bindings: serial: " Viken Dadhaniya
2024-12-04 15:07 ` Krzysztof Kozlowski
2024-12-04 15:03 ` [PATCH v1 4/7] soc: qcom: geni-se:: Add support to load QUP SE Firmware via Linux subsystem Viken Dadhaniya
2024-12-04 15:24 ` neil.armstrong
2024-12-10 4:53 ` Viken Dadhaniya
2024-12-04 20:19 ` kernel test robot
2024-12-04 22:37 ` Dmitry Baryshkov
2024-12-10 4:54 ` Viken Dadhaniya
2024-12-04 21:22 ` kernel test robot
2024-12-05 1:23 ` kernel test robot
2024-12-04 15:03 ` [PATCH v1 5/7] i2c: qcom-geni: Load i2c qup Firmware from linux side Viken Dadhaniya
2024-12-04 15:03 ` [PATCH v1 6/7] spi: geni-qcom: Load spi " Viken Dadhaniya
2024-12-04 15:03 ` [PATCH v1 7/7] serial: qcom-geni: Load UART " Viken Dadhaniya
2024-12-05 15:59 ` [PATCH v1 0/7] Add support to load QUP SE firmware from Konrad Dybcio
2024-12-09 14:45 ` neil.armstrong
2024-12-10 5:22 ` Viken Dadhaniya
2024-12-12 15:56 ` Konrad Dybcio
2024-12-10 5:06 ` Viken Dadhaniya
2024-12-12 15:58 ` Konrad Dybcio
2025-01-07 11:25 ` Caleb Connolly
2025-01-10 6:56 ` Mukesh Kumar Savaliya
2025-01-22 15:23 ` Caleb Connolly
2025-01-22 17:52 ` Mukesh Kumar Savaliya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9df703d9-b2c3-4978-9325-7ad50087e8f1@kernel.org \
--to=krzk@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=broonie@kernel.or \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=quic_anupkulk@quicinc.com \
--cc=quic_msavaliy@quicinc.com \
--cc=quic_vdadhani@quicinc.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox