public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Biju Das <biju.das.jz@bp.renesas.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Chris Brandt <Chris.Brandt@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	"linux-renesas-soc@vger.kernel.org"
	<linux-renesas-soc@vger.kernel.org>,
	"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
	biju.das.au <biju.das.au@gmail.com>
Subject: RE: [PATCH 1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support
Date: Mon, 16 Dec 2024 20:23:40 +0000	[thread overview]
Message-ID: <TY3PR01MB11346DF0FD7D74B556497FF2F863B2@TY3PR01MB11346.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <CAMuHMdXvQ5SWHkU7dXHmDtQ_fzU75ZTWSNr1ZDhq8GUgc-E8mg@mail.gmail.com>

Hi Geert,

> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 16 December 2024 16:34
> Subject: Re: [PATCH 1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support
> 
> Hi Biju,
> 
> On Mon, Dec 16, 2024 at 1:01 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Document support for the I2C Bus Interface (RIIC) found in the Renesas
> > RZ/G3E (R9A09G047) SoC. This IP is compatible with Renesas RZ/V2H
> > (R9A09G057) RIIC IP.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> 
> > --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> > @@ -26,7 +26,9 @@ properties:
> >            - const: renesas,riic-rz      # RZ/A or RZ/G2L
> >
> >        - items:
> > -          - const: renesas,riic-r9a08g045   # RZ/G3S
> > +          - enum:
> > +              - renesas,riic-r9a08g045   # RZ/G3S
> > +              - renesas,riic-r9a09g047   # RZ/G3E
> >            - const: renesas,riic-r9a09g057   # RZ/V2H(P)
> >
> >        - const: renesas,riic-r9a09g057   # RZ/V2H(P)
> 
> BTW, I think you want to make resets required for renesas,riic-r9a09g057, too.
> Or perhaps make it required unless compatible with
> renesas,riic-r7s72100 or renesas,riic-r7s9210.

Thanks for pointing out. I will make reset required property for
renesas,riic-r9a09g057 compatible devices.

Cheers,
Biju


  reply	other threads:[~2024-12-16 20:23 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-16 12:00 [PATCH 0/3] Add RZ/G3E RIIC support Biju Das
2024-12-16 12:00 ` [PATCH 1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support Biju Das
2024-12-16 16:18   ` Geert Uytterhoeven
2024-12-16 16:34   ` Geert Uytterhoeven
2024-12-16 20:23     ` Biju Das [this message]
2024-12-16 18:36   ` Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY3PR01MB11346DF0FD7D74B556497FF2F863B2@TY3PR01MB11346.jpnprd01.prod.outlook.com \
    --to=biju.das.jz@bp.renesas.com \
    --cc=Chris.Brandt@renesas.com \
    --cc=andi.shyti@kernel.org \
    --cc=biju.das.au@gmail.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
    --cc=robh@kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox