* Re: [PATCH 1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support
2024-12-16 12:00 ` [PATCH 1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support Biju Das
@ 2024-12-16 16:18 ` Geert Uytterhoeven
2024-12-16 16:34 ` Geert Uytterhoeven
2024-12-16 18:36 ` Conor Dooley
2 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2024-12-16 16:18 UTC (permalink / raw)
To: Biju Das
Cc: Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chris Brandt, Magnus Damm, Wolfram Sang, linux-renesas-soc,
linux-i2c, devicetree, Prabhakar Mahadev Lad, Biju Das
On Mon, Dec 16, 2024 at 1:01 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Document support for the I2C Bus Interface (RIIC) found in the Renesas
> RZ/G3E (R9A09G047) SoC. This IP is compatible with Renesas RZ/V2H
> (R9A09G057) RIIC IP.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support
2024-12-16 12:00 ` [PATCH 1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support Biju Das
2024-12-16 16:18 ` Geert Uytterhoeven
@ 2024-12-16 16:34 ` Geert Uytterhoeven
2024-12-16 20:23 ` Biju Das
2024-12-16 18:36 ` Conor Dooley
2 siblings, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2024-12-16 16:34 UTC (permalink / raw)
To: Biju Das
Cc: Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chris Brandt, Geert Uytterhoeven, Magnus Damm, Wolfram Sang,
linux-renesas-soc, linux-i2c, devicetree, Prabhakar Mahadev Lad,
Biju Das
Hi Biju,
On Mon, Dec 16, 2024 at 1:01 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Document support for the I2C Bus Interface (RIIC) found in the Renesas
> RZ/G3E (R9A09G047) SoC. This IP is compatible with Renesas RZ/V2H
> (R9A09G057) RIIC IP.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> @@ -26,7 +26,9 @@ properties:
> - const: renesas,riic-rz # RZ/A or RZ/G2L
>
> - items:
> - - const: renesas,riic-r9a08g045 # RZ/G3S
> + - enum:
> + - renesas,riic-r9a08g045 # RZ/G3S
> + - renesas,riic-r9a09g047 # RZ/G3E
> - const: renesas,riic-r9a09g057 # RZ/V2H(P)
>
> - const: renesas,riic-r9a09g057 # RZ/V2H(P)
BTW, I think you want to make resets required for renesas,riic-r9a09g057, too.
Or perhaps make it required unless compatible with
renesas,riic-r7s72100 or renesas,riic-r7s9210.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* RE: [PATCH 1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support
2024-12-16 16:34 ` Geert Uytterhoeven
@ 2024-12-16 20:23 ` Biju Das
0 siblings, 0 replies; 6+ messages in thread
From: Biju Das @ 2024-12-16 20:23 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chris Brandt, Geert Uytterhoeven, Magnus Damm, Wolfram Sang,
linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, Prabhakar Mahadev Lad, biju.das.au
Hi Geert,
> -----Original Message-----
> From: Geert Uytterhoeven <geert@linux-m68k.org>
> Sent: 16 December 2024 16:34
> Subject: Re: [PATCH 1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support
>
> Hi Biju,
>
> On Mon, Dec 16, 2024 at 1:01 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Document support for the I2C Bus Interface (RIIC) found in the Renesas
> > RZ/G3E (R9A09G047) SoC. This IP is compatible with Renesas RZ/V2H
> > (R9A09G057) RIIC IP.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>
> > --- a/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> > +++ b/Documentation/devicetree/bindings/i2c/renesas,riic.yaml
> > @@ -26,7 +26,9 @@ properties:
> > - const: renesas,riic-rz # RZ/A or RZ/G2L
> >
> > - items:
> > - - const: renesas,riic-r9a08g045 # RZ/G3S
> > + - enum:
> > + - renesas,riic-r9a08g045 # RZ/G3S
> > + - renesas,riic-r9a09g047 # RZ/G3E
> > - const: renesas,riic-r9a09g057 # RZ/V2H(P)
> >
> > - const: renesas,riic-r9a09g057 # RZ/V2H(P)
>
> BTW, I think you want to make resets required for renesas,riic-r9a09g057, too.
> Or perhaps make it required unless compatible with
> renesas,riic-r7s72100 or renesas,riic-r7s9210.
Thanks for pointing out. I will make reset required property for
renesas,riic-r9a09g057 compatible devices.
Cheers,
Biju
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support
2024-12-16 12:00 ` [PATCH 1/3] dt-bindings: i2c: renesas,riic: Document the R9A09G047 support Biju Das
2024-12-16 16:18 ` Geert Uytterhoeven
2024-12-16 16:34 ` Geert Uytterhoeven
@ 2024-12-16 18:36 ` Conor Dooley
2 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2024-12-16 18:36 UTC (permalink / raw)
To: Biju Das
Cc: Andi Shyti, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Chris Brandt, Geert Uytterhoeven, Magnus Damm, Wolfram Sang,
linux-renesas-soc, linux-i2c, devicetree, Prabhakar Mahadev Lad,
Biju Das
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
On Mon, Dec 16, 2024 at 12:00:23PM +0000, Biju Das wrote:
> Document support for the I2C Bus Interface (RIIC) found in the Renesas
> RZ/G3E (R9A09G047) SoC. This IP is compatible with Renesas RZ/V2H
> (R9A09G057) RIIC IP.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread