From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dejin Zheng <zhengdejin5@gmail.com>
Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
wsa@kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH i2c-next] i2c: designware: Consolidate pci_free_irq_vectors to a single place
Date: Mon, 15 Feb 2021 15:28:48 +0200 [thread overview]
Message-ID: <YCp3EGc6N5iMlvfm@smile.fi.intel.com> (raw)
In-Reply-To: <YCp1KL/+YYxmr7vO@smile.fi.intel.com>
On Mon, Feb 15, 2021 at 03:20:40PM +0200, Andy Shevchenko wrote:
> On Sun, Feb 14, 2021 at 02:45:29PM +0800, Dejin Zheng wrote:
> > Consolidate pci_free_irq_vectors to a single place using "goto free_irq"
> > for simplify the code.
FYI, you may rather to introduce a pcim_alloc_irq_vectors() and drop all these
calls altogether.
Note to everybody: PCIm is not ideal, but this piece is being called whenever
pcim_enable_device() makes resources manageable. The problem here is the
naming.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2021-02-15 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-14 6:45 [PATCH i2c-next] i2c: designware: Consolidate pci_free_irq_vectors to a single place Dejin Zheng
2021-02-15 9:36 ` Jarkko Nikula
2021-02-15 12:45 ` Dejin Zheng
2021-02-15 13:20 ` Andy Shevchenko
2021-02-15 13:28 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YCp3EGc6N5iMlvfm@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=wsa@kernel.org \
--cc=zhengdejin5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox