From: Wolfram Sang <wsa@kernel.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Cc: linux-i2c@vger.kernel.org, michal.simek@xilinx.com, git@xilinx.com
Subject: Re: [PATCH v2] i2c-xiic: Fix the type check for xiic_wakeup
Date: Mon, 13 Jun 2022 16:54:45 +0200 [thread overview]
Message-ID: <YqdPtexPiukMlUcG@shikoro> (raw)
In-Reply-To: <20220613043002.28152-1-shubhrajyoti.datta@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 573 bytes --]
On Mon, Jun 13, 2022 at 10:00:02AM +0530, Shubhrajyoti Datta wrote:
> Fix the coverity warning
> mixed_enum_type: enumerated type mixed with another type
>
> We are passing an enum in the xiic_wakeup lets change
> the function parameters to reflect that.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
What is the difference to the V2 you sent 4 days earlier?
> enum xilinx_i2c_state {
> - STATE_DONE,
> - STATE_ERROR,
> - STATE_START
> + STATE_DONE = 0,
> + STATE_ERROR = 1,
> + STATE_START = 2
No need for initializers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-06-13 18:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 4:30 [PATCH v2] i2c-xiic: Fix the type check for xiic_wakeup Shubhrajyoti Datta
2022-06-13 14:54 ` Wolfram Sang [this message]
2022-06-14 6:30 ` Shubhrajyoti Datta
2022-06-14 7:01 ` Michal Simek
2022-06-14 8:11 ` Wolfram Sang
2022-06-14 8:18 ` Greg Kroah-Hartman
2022-06-14 9:01 ` Michal Simek
-- strict thread matches above, loose matches on Subject: below --
2022-06-09 15:37 Shubhrajyoti Datta
2022-06-09 15:55 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqdPtexPiukMlUcG@shikoro \
--to=wsa@kernel.org \
--cc=git@xilinx.com \
--cc=linux-i2c@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox