From: Wolfram Sang <wsa@kernel.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>,
linux-i2c@vger.kernel.org, git@xilinx.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2] i2c-xiic: Fix the type check for xiic_wakeup
Date: Tue, 14 Jun 2022 10:11:40 +0200 [thread overview]
Message-ID: <YqhCvJdWw+g9ZZFL@shikoro> (raw)
In-Reply-To: <36da7a53-9bb4-26ae-0ac5-1ebcdf0ac695@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
> Actually this was recommended by Greg in one of our thread here.
> https://lore.kernel.org/all/20200318125003.GA2727094@kroah.com/
It is in the C standard, so any compiler not adhering to it has a bug.
It is especially not important here because we use the enums only
locally and do not export.
> That's why we started to initialize all values in enums in our code.
> It shouldn't be really any problem to do so.
It may be more readable if you have dozens of them, but it also adds the
possibility of copy&paste errors.
I think I'll take V3 here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-06-14 8:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-13 4:30 [PATCH v2] i2c-xiic: Fix the type check for xiic_wakeup Shubhrajyoti Datta
2022-06-13 14:54 ` Wolfram Sang
2022-06-14 6:30 ` Shubhrajyoti Datta
2022-06-14 7:01 ` Michal Simek
2022-06-14 8:11 ` Wolfram Sang [this message]
2022-06-14 8:18 ` Greg Kroah-Hartman
2022-06-14 9:01 ` Michal Simek
-- strict thread matches above, loose matches on Subject: below --
2022-06-09 15:37 Shubhrajyoti Datta
2022-06-09 15:55 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YqhCvJdWw+g9ZZFL@shikoro \
--to=wsa@kernel.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-i2c@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox