From: Wolfram Sang <wsa@kernel.org>
To: XU pengfei <xupengfei@nfschina.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] drivers: remove unnecessary (void*) conversions.
Date: Sun, 24 Jul 2022 07:40:17 +0200 [thread overview]
Message-ID: <YtzbQZKJk+qS9PMs@shikoro> (raw)
In-Reply-To: <20220629060952.4749-1-xupengfei@nfschina.com>
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
On Wed, Jun 29, 2022 at 02:09:52PM +0800, XU pengfei wrote:
> remove unnecessary void* type casting.
>
> Signed-off-by: XU pengfei <xupengfei@nfschina.com>
Correct, but $subject really needs to contain the subsystem and the
driver. "drivers:" is way too generic. Check 'git log' to see how
subsystems prefer their $subjects.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-07-24 5:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-29 6:09 [PATCH 1/1] drivers: remove unnecessary (void*) conversions XU pengfei
2022-07-24 5:40 ` Wolfram Sang [this message]
2022-07-25 1:33 ` [PATCH v2] i2c/busses/drivers/img: " XU pengfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YtzbQZKJk+qS9PMs@shikoro \
--to=wsa@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xupengfei@nfschina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox