* [PATCH 1/1] drivers: remove unnecessary (void*) conversions.
@ 2022-06-29 6:09 XU pengfei
2022-07-24 5:40 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: XU pengfei @ 2022-06-29 6:09 UTC (permalink / raw)
To: linux-i2c; +Cc: linux-kernel, XU pengfei
remove unnecessary void* type casting.
Signed-off-by: XU pengfei <xupengfei@nfschina.com>
---
drivers/i2c/busses/i2c-img-scb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c
index 8e987945ed45..d72211cfda03 100644
--- a/drivers/i2c/busses/i2c-img-scb.c
+++ b/drivers/i2c/busses/i2c-img-scb.c
@@ -913,7 +913,7 @@ static unsigned int img_i2c_auto(struct img_i2c *i2c,
static irqreturn_t img_i2c_isr(int irq, void *dev_id)
{
- struct img_i2c *i2c = (struct img_i2c *)dev_id;
+ struct img_i2c *i2c = dev_id;
u32 int_status, line_status;
/* We handle transaction completion AFTER accessing registers */
unsigned int hret;
--
2.18.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 1/1] drivers: remove unnecessary (void*) conversions.
2022-06-29 6:09 [PATCH 1/1] drivers: remove unnecessary (void*) conversions XU pengfei
@ 2022-07-24 5:40 ` Wolfram Sang
2022-07-25 1:33 ` [PATCH v2] i2c/busses/drivers/img: " XU pengfei
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2022-07-24 5:40 UTC (permalink / raw)
To: XU pengfei; +Cc: linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 337 bytes --]
On Wed, Jun 29, 2022 at 02:09:52PM +0800, XU pengfei wrote:
> remove unnecessary void* type casting.
>
> Signed-off-by: XU pengfei <xupengfei@nfschina.com>
Correct, but $subject really needs to contain the subsystem and the
driver. "drivers:" is way too generic. Check 'git log' to see how
subsystems prefer their $subjects.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] i2c/busses/drivers/img: remove unnecessary (void*) conversions.
2022-07-24 5:40 ` Wolfram Sang
@ 2022-07-25 1:33 ` XU pengfei
0 siblings, 0 replies; 3+ messages in thread
From: XU pengfei @ 2022-07-25 1:33 UTC (permalink / raw)
To: wsa; +Cc: linux-i2c, linux-kernel, xupengfei
remove unnecessary void* type casting.
Signed-off-by: XU pengfei <xupengfei@nfschina.com>
---
drivers/i2c/busses/i2c-img-scb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-img-scb.c b/drivers/i2c/busses/i2c-img-scb.c
index 8e987945ed45..d72211cfda03 100644
--- a/drivers/i2c/busses/i2c-img-scb.c
+++ b/drivers/i2c/busses/i2c-img-scb.c
@@ -913,7 +913,7 @@ static unsigned int img_i2c_auto(struct img_i2c *i2c,
static irqreturn_t img_i2c_isr(int irq, void *dev_id)
{
- struct img_i2c *i2c = (struct img_i2c *)dev_id;
+ struct img_i2c *i2c = dev_id;
u32 int_status, line_status;
/* We handle transaction completion AFTER accessing registers */
unsigned int hret;
--
2.18.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-25 1:34 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-06-29 6:09 [PATCH 1/1] drivers: remove unnecessary (void*) conversions XU pengfei
2022-07-24 5:40 ` Wolfram Sang
2022-07-25 1:33 ` [PATCH v2] i2c/busses/drivers/img: " XU pengfei
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox