* [PATCH v2] docs: i2c: piix4: Fix typos, add markup, drop link
@ 2022-08-25 13:01 Jean Delvare
2022-08-29 20:09 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2022-08-25 13:01 UTC (permalink / raw)
To: Linux I2C; +Cc: Bruce Duncan, Wolfram Sang, trivial
From: Bruce Duncan <bwduncan@gmail.com>
[JD: Update the subject
One more typo fixed
Drop the link to lm-sensors' README, it's irrelevant]
Signed-off-by: Bruce Duncan <bwduncan@gmail.com>
Reviewed-by: Jean Delvare <jdelvare@suse.de>
---
Documentation/i2c/busses/i2c-piix4.rst | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
--- linux-5.19.orig/Documentation/i2c/busses/i2c-piix4.rst 2022-07-31 23:03:01.000000000 +0200
+++ linux-5.19/Documentation/i2c/busses/i2c-piix4.rst 2022-08-25 14:58:36.733243769 +0200
@@ -64,7 +64,7 @@ try to enable it. THIS IS VERY DANGEROUS
crashes, data corruption, etc.). Try this only as a last resort (try BIOS
updates first, for example), and backup first! An even more dangerous
option is 'force_addr=<IOPORT>'. This will not only enable the PIIX4 like
-'force' foes, but it will also set a new base I/O port address. The SMBus
+'force' does, but it will also set a new base I/O port address. The SMBus
parts of the PIIX4 needs a range of 8 of these addresses to function
correctly. If these addresses are already reserved by some other device,
you will get into big trouble! DON'T USE THIS IF YOU ARE NOT VERY SURE
@@ -86,15 +86,15 @@ If you own Force CPCI735 motherboard or
to change the SMBus Interrupt Select register so the SMBus controller uses
the SMI mode.
-1) Use lspci command and locate the PCI device with the SMBus controller:
+1) Use ``lspci`` command and locate the PCI device with the SMBus controller:
00:0f.0 ISA bridge: ServerWorks OSB4 South Bridge (rev 4f)
The line may vary for different chipsets. Please consult the driver source
- for all possible PCI ids (and lspci -n to match them). Lets assume the
+ for all possible PCI ids (and ``lspci -n`` to match them). Let's assume the
device is located at 00:0f.0.
2) Now you just need to change the value in 0xD2 register. Get it first with
- command: lspci -xxx -s 00:0f.0
+ command: ``lspci -xxx -s 00:0f.0``
If the value is 0x3 then you need to change it to 0x1:
- setpci -s 00:0f.0 d2.b=1
+ ``setpci -s 00:0f.0 d2.b=1``
Please note that you don't need to do that in all cases, just when the SMBus is
not working properly.
@@ -109,6 +109,3 @@ which can easily get corrupted due to a
Thinkpad laptops, but desktop systems may also be affected. We have no list
of all affected systems, so the only safe solution was to prevent access to
the SMBus on all IBM systems (detected using DMI data.)
-
-For additional information, read:
-http://www.lm-sensors.org/browser/lm-sensors/trunk/README
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] docs: i2c: piix4: Fix typos, add markup, drop link
2022-08-25 13:01 [PATCH v2] docs: i2c: piix4: Fix typos, add markup, drop link Jean Delvare
@ 2022-08-29 20:09 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2022-08-29 20:09 UTC (permalink / raw)
To: Jean Delvare; +Cc: Linux I2C, Bruce Duncan, trivial
[-- Attachment #1: Type: text/plain, Size: 368 bytes --]
On Thu, Aug 25, 2022 at 03:01:41PM +0200, Jean Delvare wrote:
> From: Bruce Duncan <bwduncan@gmail.com>
>
> [JD: Update the subject
> One more typo fixed
> Drop the link to lm-sensors' README, it's irrelevant]
>
> Signed-off-by: Bruce Duncan <bwduncan@gmail.com>
> Reviewed-by: Jean Delvare <jdelvare@suse.de>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-08-29 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-25 13:01 [PATCH v2] docs: i2c: piix4: Fix typos, add markup, drop link Jean Delvare
2022-08-29 20:09 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox