[PATCH] i2c: amd756: Remove TODO

[PATCH] i2c: amd756: Remove TODO

[Atharva Tiwari]

removing TODO in i2c-amd756.c because Andi Shyti said on
https://lore.kernel.org/all/ovddzx2zitp6lqjdasinn2zaaefp35y4mspol3v3x5rk3tddgo@kgcwexuai2ir/
: "I think the real solution would be to just
remove the comments altogether" so yeah this patch
just removes TODO

Signed-off-by: Atharva Tiwari <evepolonium@gmail.com>
---
 drivers/i2c/busses/i2c-amd756.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-amd756.c b/drivers/i2c/busses/i2c-amd756.c
index fa0d5a2c3732..3621c02f1cba 100644
--- a/drivers/i2c/busses/i2c-amd756.c
+++ b/drivers/i2c/busses/i2c-amd756.c
@@ -211,7 +211,7 @@ static s32 amd756_access(struct i2c_adapter * adap, u16 addr,
 		       SMB_HOST_ADDRESS);
 		outb_p(command, SMB_HOST_COMMAND);
 		if (read_write == I2C_SMBUS_WRITE)
-			outw_p(data->word, SMB_HOST_DATA);	/* TODO: endian???? */
+			outw_p(data->word, SMB_HOST_DATA);
 		size = AMD756_WORD_DATA;
 		break;
 	case I2C_SMBUS_BLOCK_DATA:
@@ -256,7 +256,7 @@ static s32 amd756_access(struct i2c_adapter * adap, u16 addr,
 		data->byte = inw_p(SMB_HOST_DATA);
 		break;
 	case AMD756_WORD_DATA:
-		data->word = inw_p(SMB_HOST_DATA);	/* TODO: endian???? */
+		data->word = inw_p(SMB_HOST_DATA);
 		break;
 	case AMD756_BLOCK_DATA:
 		data->block[0] = inw_p(SMB_HOST_DATA) & 0x3f;
-- 
2.43.0

Re: [PATCH] i2c: amd756: Remove TODO

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

On Mon, Jan 13, 2025 at 06:27:28PM +0530, Atharva Tiwari wrote:
> removing TODO in i2c-amd756.c because Andi Shyti said on
> https://lore.kernel.org/all/ovddzx2zitp6lqjdasinn2zaaefp35y4mspol3v3x5rk3tddgo@kgcwexuai2ir/
> : "I think the real solution would be to just
> remove the comments altogether" so yeah this patch
> just removes TODO
> 
> Signed-off-by: Atharva Tiwari <evepolonium@gmail.com>

Reverted your original commit, reworded the commit message (please check
how once I pushed out) and applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]