* [PATCH] i2c: mux: demux-pinctrl: check initial mux selection, too
@ 2025-01-15 7:29 Wolfram Sang
2025-01-16 17:20 ` Wolfram Sang
0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2025-01-15 7:29 UTC (permalink / raw)
To: linux-renesas-soc; +Cc: Wolfram Sang, Peter Rosin, Rob Herring, linux-i2c
When misconfigured, the initial setup of the current mux channel can
fail, too. It must be checked as well.
Fixes: 50a5ba876908 ("i2c: mux: demux-pinctrl: add driver")
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Tested with a Renesas Lager board (R-Car H2).
drivers/i2c/muxes/i2c-demux-pinctrl.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/i2c/muxes/i2c-demux-pinctrl.c b/drivers/i2c/muxes/i2c-demux-pinctrl.c
index dce18f763a09..b204e5a21ce6 100644
--- a/drivers/i2c/muxes/i2c-demux-pinctrl.c
+++ b/drivers/i2c/muxes/i2c-demux-pinctrl.c
@@ -261,7 +261,9 @@ static int i2c_demux_pinctrl_probe(struct platform_device *pdev)
pm_runtime_no_callbacks(&pdev->dev);
/* switch to first parent as active master */
- i2c_demux_activate_master(priv, 0);
+ err = i2c_demux_activate_master(priv, 0);
+ if (err)
+ goto err_rollback;
err = device_create_file(&pdev->dev, &dev_attr_available_masters);
if (err)
--
2.39.2
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] i2c: mux: demux-pinctrl: check initial mux selection, too
2025-01-15 7:29 [PATCH] i2c: mux: demux-pinctrl: check initial mux selection, too Wolfram Sang
@ 2025-01-16 17:20 ` Wolfram Sang
0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2025-01-16 17:20 UTC (permalink / raw)
To: linux-renesas-soc; +Cc: Peter Rosin, Rob Herring, linux-i2c
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
On Wed, Jan 15, 2025 at 08:29:45AM +0100, Wolfram Sang wrote:
> When misconfigured, the initial setup of the current mux channel can
> fail, too. It must be checked as well.
>
> Fixes: 50a5ba876908 ("i2c: mux: demux-pinctrl: add driver")
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-01-16 17:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-01-15 7:29 [PATCH] i2c: mux: demux-pinctrl: check initial mux selection, too Wolfram Sang
2025-01-16 17:20 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox