* [PATCH] i2c: tegra: Return if SMBUS message length is zero
@ 2025-03-20 6:22 Akhil R
2025-03-20 7:21 ` Wolfram Sang
0 siblings, 1 reply; 3+ messages in thread
From: Akhil R @ 2025-03-20 6:22 UTC (permalink / raw)
To: ldewangan, digetx, andi.shyti, thierry.reding, jonathanh, wsa,
linux-i2c, linux-tegra, linux-kernel
Cc: Akhil R
For SMBUS block read, do not continue to read if the message length
passed from the device is '0'.
Signed-off-by: Akhil R <akhilrajeev@nvidia.com>
---
drivers/i2c/busses/i2c-tegra.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/busses/i2c-tegra.c b/drivers/i2c/busses/i2c-tegra.c
index 87976e99e6d0..273d6aaa427b 100644
--- a/drivers/i2c/busses/i2c-tegra.c
+++ b/drivers/i2c/busses/i2c-tegra.c
@@ -1393,7 +1393,7 @@ static int tegra_i2c_xfer(struct i2c_adapter *adap, struct i2c_msg msgs[],
/* If M_RECV_LEN use ContinueXfer to read the first byte */
if (msgs[i].flags & I2C_M_RECV_LEN) {
ret = tegra_i2c_xfer_msg(i2c_dev, &msgs[i], MSG_END_CONTINUE);
- if (ret)
+ if (ret || msgs[i].buf[0] == 0)
break;
/* Set the msg length from first byte */
msgs[i].len += msgs[i].buf[0];
--
2.43.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] i2c: tegra: Return if SMBUS message length is zero
2025-03-20 6:22 [PATCH] i2c: tegra: Return if SMBUS message length is zero Akhil R
@ 2025-03-20 7:21 ` Wolfram Sang
2025-03-20 13:23 ` Akhil R
0 siblings, 1 reply; 3+ messages in thread
From: Wolfram Sang @ 2025-03-20 7:21 UTC (permalink / raw)
To: Akhil R
Cc: ldewangan, digetx, andi.shyti, thierry.reding, jonathanh, wsa,
linux-i2c, linux-tegra, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 229 bytes --]
On Thu, Mar 20, 2025 at 11:52:01AM +0530, Akhil R wrote:
> For SMBUS block read, do not continue to read if the message length
> passed from the device is '0'.
You probably should also check for I2C_SMBUS_BLOCK_MAX while here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH] i2c: tegra: Return if SMBUS message length is zero
2025-03-20 7:21 ` Wolfram Sang
@ 2025-03-20 13:23 ` Akhil R
0 siblings, 0 replies; 3+ messages in thread
From: Akhil R @ 2025-03-20 13:23 UTC (permalink / raw)
To: Wolfram Sang
Cc: Laxman Dewangan, digetx@gmail.com, andi.shyti@kernel.org,
thierry.reding@gmail.com, Jon Hunter, wsa@kernel.org,
linux-i2c@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
> > For SMBUS block read, do not continue to read if the message length
> > passed from the device is '0'.
>
> You probably should also check for I2C_SMBUS_BLOCK_MAX while here.
Done. Posted a new version with this additional check.
Thanks,
Akhil
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-20 13:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-20 6:22 [PATCH] i2c: tegra: Return if SMBUS message length is zero Akhil R
2025-03-20 7:21 ` Wolfram Sang
2025-03-20 13:23 ` Akhil R
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox