From: Wolfram Sang <wsa@kernel.org>
To: Hans Hu <HansHu-oc@zhaoxin.com>
Cc: andi.shyti@kernel.org, linux-i2c@vger.kernel.org,
cobechen@zhaoxin.com, TonyWWang@zhaoxin.com
Subject: Re: [PATCH v2 1/2] i2c: wmt: split out i2c-viai2c-common.{c,h}
Date: Mon, 28 Aug 2023 09:37:07 +0200 [thread overview]
Message-ID: <ZOxOo+3j46gMmWaI@ninjato> (raw)
In-Reply-To: <fa22abcd-c100-c633-4625-5a2324e3337f@zhaoxin.com>
[-- Attachment #1: Type: text/plain, Size: 424 bytes --]
> i2c-zhaoxin-objs:= i2c-viai2c-common.o i2c-zhaoxin-plt.o
> obj-$(CONFIG_I2C_ZHAOXIN) += i2c-zhaoxin.o
Yes, exactly!
> i2c-wmt-objs:= i2c-viai2c-common.o i2c-wmt-plt.o
> obj-$(CONFIG_I2C_WMT) += i2c-wmt.o
>
> But I'm not sure which way is more appropriate:
> change file name i2c-wmt.c to i2c-wmt-plt.c.(I prefer this)
I prefer this, too!
Thank you and happy hacking!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-08-28 7:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 8:40 [PATCH v2 0/2] i2c: add support for Zhaoxin I2C controller Hans Hu
2023-08-14 8:40 ` [PATCH v2 1/2] i2c: wmt: split out i2c-viai2c-common.{c,h} Hans Hu
2023-08-25 20:02 ` Wolfram Sang
2023-08-28 2:42 ` Hans Hu
2023-08-28 6:00 ` Wolfram Sang
2023-08-28 7:25 ` Hans Hu
2023-08-28 7:37 ` Wolfram Sang [this message]
2023-08-14 8:40 ` [PATCH v2 2/2] i2c: add support for Zhaoxin I2C controller Hans Hu
2023-08-25 20:04 ` Wolfram Sang
2023-08-28 2:50 ` Hans Hu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZOxOo+3j46gMmWaI@ninjato \
--to=wsa@kernel.org \
--cc=HansHu-oc@zhaoxin.com \
--cc=TonyWWang@zhaoxin.com \
--cc=andi.shyti@kernel.org \
--cc=cobechen@zhaoxin.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox