[PATCH] i2c: mux: gpio: adhere to coding style

[PATCH] i2c: mux: gpio: adhere to coding style

[Wolfram Sang]

Advertise our coding style by following it :)

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 drivers/i2c/muxes/i2c-mux-gpio.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
index 5ca03bd34c8d..0419c7453281 100644
--- a/drivers/i2c/muxes/i2c-mux-gpio.c
+++ b/drivers/i2c/muxes/i2c-mux-gpio.c
@@ -23,7 +23,7 @@ struct gpiomux {
 	struct gpio_desc **gpios;
 };
 
-static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val)
+static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned int val)
 {
 	DECLARE_BITMAP(values, BITS_PER_TYPE(val));
 
@@ -59,7 +59,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
 	struct device_node *adapter_np;
 	struct i2c_adapter *adapter = NULL;
 	struct fwnode_handle *child;
-	unsigned *values;
+	unsigned int *values;
 	int rc, i = 0;
 
 	if (is_of_node(fwnode)) {
@@ -102,7 +102,6 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
 	device_for_each_child_node(dev, child) {
 		if (is_of_node(child)) {
 			fwnode_property_read_u32(child, "reg", values + i);
-
 		} else if (is_acpi_node(child)) {
 			rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i);
 			if (rc) {
@@ -127,7 +126,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
 	struct gpiomux *mux;
 	struct i2c_adapter *parent;
 	struct i2c_adapter *root;
-	unsigned initial_state;
+	unsigned int initial_state;
 	int i, ngpios, ret;
 
 	mux = devm_kzalloc(&pdev->dev, sizeof(*mux), GFP_KERNEL);
-- 
2.35.1

Re: [PATCH] i2c: mux: gpio: adhere to coding style

[Geert Uytterhoeven]

On Fri, Sep 22, 2023 at 1:51 AM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Advertise our coding style by following it :)
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] i2c: mux: gpio: adhere to coding style

[Peter Rosin]

2023-09-21 at 10:57, Wolfram Sang wrote:
> Advertise our coding style by following it :)
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

A no-brainer...

Acked-by: Peter Rosin <peda@axentia.se>

Cheers,
Peter

> ---
>  drivers/i2c/muxes/i2c-mux-gpio.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
> index 5ca03bd34c8d..0419c7453281 100644
> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
> @@ -23,7 +23,7 @@ struct gpiomux {
>  	struct gpio_desc **gpios;
>  };
>  
> -static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned val)
> +static void i2c_mux_gpio_set(const struct gpiomux *mux, unsigned int val)
>  {
>  	DECLARE_BITMAP(values, BITS_PER_TYPE(val));
>  
> @@ -59,7 +59,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>  	struct device_node *adapter_np;
>  	struct i2c_adapter *adapter = NULL;
>  	struct fwnode_handle *child;
> -	unsigned *values;
> +	unsigned int *values;
>  	int rc, i = 0;
>  
>  	if (is_of_node(fwnode)) {
> @@ -102,7 +102,6 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>  	device_for_each_child_node(dev, child) {
>  		if (is_of_node(child)) {
>  			fwnode_property_read_u32(child, "reg", values + i);
> -
>  		} else if (is_acpi_node(child)) {
>  			rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i);
>  			if (rc) {
> @@ -127,7 +126,7 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev)
>  	struct gpiomux *mux;
>  	struct i2c_adapter *parent;
>  	struct i2c_adapter *root;
> -	unsigned initial_state;
> +	unsigned int initial_state;
>  	int i, ngpios, ret;
>  
>  	mux = devm_kzalloc(&pdev->dev, sizeof(*mux), GFP_KERNEL);

Re: [PATCH] i2c: mux: gpio: adhere to coding style

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

On Thu, Sep 21, 2023 at 10:57:51AM +0200, Wolfram Sang wrote:
> Advertise our coding style by following it :)
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

Applied to for-next, thanks!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]