* [PATCH] ipmi: ipmb: Remove I2C_CLASS_HWMON from drivers w/o detect and address_list
@ 2024-01-27 15:15 Heiner Kallweit
2024-02-03 20:37 ` Wolfram Sang
2024-03-02 17:47 ` Heiner Kallweit
0 siblings, 2 replies; 3+ messages in thread
From: Heiner Kallweit @ 2024-01-27 15:15 UTC (permalink / raw)
To: Corey Minyard; +Cc: openipmi-developer, linux-i2c@vger.kernel.org
Class-based I2C probing requires detect() and address_list to be
set in the I2C client driver, see checks in i2c_detect().
It's misleading to declare I2C_CLASS_HWMON support if this
precondition isn't met.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
drivers/char/ipmi/ipmi_ipmb.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c
index 4e335832f..9e5c6d682 100644
--- a/drivers/char/ipmi/ipmi_ipmb.c
+++ b/drivers/char/ipmi/ipmi_ipmb.c
@@ -567,7 +567,6 @@ static const struct i2c_device_id ipmi_ipmb_id[] = {
MODULE_DEVICE_TABLE(i2c, ipmi_ipmb_id);
static struct i2c_driver ipmi_ipmb_driver = {
- .class = I2C_CLASS_HWMON,
.driver = {
.name = DEVICE_NAME,
.of_match_table = of_ipmi_ipmb_match,
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ipmi: ipmb: Remove I2C_CLASS_HWMON from drivers w/o detect and address_list
2024-01-27 15:15 [PATCH] ipmi: ipmb: Remove I2C_CLASS_HWMON from drivers w/o detect and address_list Heiner Kallweit
@ 2024-02-03 20:37 ` Wolfram Sang
2024-03-02 17:47 ` Heiner Kallweit
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2024-02-03 20:37 UTC (permalink / raw)
To: Heiner Kallweit
Cc: Corey Minyard, openipmi-developer, linux-i2c@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
On Sat, Jan 27, 2024 at 04:15:06PM +0100, Heiner Kallweit wrote:
> Class-based I2C probing requires detect() and address_list to be
> set in the I2C client driver, see checks in i2c_detect().
> It's misleading to declare I2C_CLASS_HWMON support if this
> precondition isn't met.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ipmi: ipmb: Remove I2C_CLASS_HWMON from drivers w/o detect and address_list
2024-01-27 15:15 [PATCH] ipmi: ipmb: Remove I2C_CLASS_HWMON from drivers w/o detect and address_list Heiner Kallweit
2024-02-03 20:37 ` Wolfram Sang
@ 2024-03-02 17:47 ` Heiner Kallweit
1 sibling, 0 replies; 3+ messages in thread
From: Heiner Kallweit @ 2024-03-02 17:47 UTC (permalink / raw)
To: Corey Minyard, Wolfram Sang; +Cc: openipmi-developer, linux-i2c@vger.kernel.org
On 27.01.2024 16:15, Heiner Kallweit wrote:
> Class-based I2C probing requires detect() and address_list to be
> set in the I2C client driver, see checks in i2c_detect().
> It's misleading to declare I2C_CLASS_HWMON support if this
> precondition isn't met.
>
Any feedback here? Should this better go through the I2C tree?
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> drivers/char/ipmi/ipmi_ipmb.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/char/ipmi/ipmi_ipmb.c b/drivers/char/ipmi/ipmi_ipmb.c
> index 4e335832f..9e5c6d682 100644
> --- a/drivers/char/ipmi/ipmi_ipmb.c
> +++ b/drivers/char/ipmi/ipmi_ipmb.c
> @@ -567,7 +567,6 @@ static const struct i2c_device_id ipmi_ipmb_id[] = {
> MODULE_DEVICE_TABLE(i2c, ipmi_ipmb_id);
>
> static struct i2c_driver ipmi_ipmb_driver = {
> - .class = I2C_CLASS_HWMON,
> .driver = {
> .name = DEVICE_NAME,
> .of_match_table = of_ipmi_ipmb_match,
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-03-02 17:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-27 15:15 [PATCH] ipmi: ipmb: Remove I2C_CLASS_HWMON from drivers w/o detect and address_list Heiner Kallweit
2024-02-03 20:37 ` Wolfram Sang
2024-03-02 17:47 ` Heiner Kallweit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox