public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] media: ddbridge: Remove unused class-based I2C autoprobing code
@ 2024-01-26 22:39 Heiner Kallweit
  2024-01-27  7:12 ` Wolfram Sang
  0 siblings, 1 reply; 2+ messages in thread
From: Heiner Kallweit @ 2024-01-26 22:39 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-media, linux-i2c@vger.kernel.org

The I2C_CLASS_TV_xxx constants don't exist in kernel code, seems like
this was copied from out-of-tree code. The supported I2C_CLASS_xxx
constants reside in include/linux/i2c.h.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/media/pci/ddbridge/ddbridge-i2c.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/drivers/media/pci/ddbridge/ddbridge-i2c.c b/drivers/media/pci/ddbridge/ddbridge-i2c.c
index c894be180..2db65eab2 100644
--- a/drivers/media/pci/ddbridge/ddbridge-i2c.c
+++ b/drivers/media/pci/ddbridge/ddbridge-i2c.c
@@ -170,13 +170,6 @@ static int ddb_i2c_add(struct ddb *dev, struct ddb_i2c *i2c,
 
 	adap = &i2c->adap;
 	i2c_set_adapdata(adap, i2c);
-#ifdef I2C_ADAP_CLASS_TV_DIGITAL
-	adap->class = I2C_ADAP_CLASS_TV_DIGITAL | I2C_CLASS_TV_ANALOG;
-#else
-#ifdef I2C_CLASS_TV_ANALOG
-	adap->class = I2C_CLASS_TV_ANALOG;
-#endif
-#endif
 	snprintf(adap->name, I2C_NAME_SIZE, "ddbridge_%02x.%x.%x",
 		 dev->nr, i2c->link, i);
 	adap->algo = &ddb_i2c_algo;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] media: ddbridge: Remove unused class-based I2C autoprobing code
  2024-01-26 22:39 [PATCH] media: ddbridge: Remove unused class-based I2C autoprobing code Heiner Kallweit
@ 2024-01-27  7:12 ` Wolfram Sang
  0 siblings, 0 replies; 2+ messages in thread
From: Wolfram Sang @ 2024-01-27  7:12 UTC (permalink / raw)
  To: Heiner Kallweit
  Cc: Mauro Carvalho Chehab, linux-media, linux-i2c@vger.kernel.org

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

On Fri, Jan 26, 2024 at 11:39:58PM +0100, Heiner Kallweit wrote:
> The I2C_CLASS_TV_xxx constants don't exist in kernel code, seems like
> this was copied from out-of-tree code. The supported I2C_CLASS_xxx
> constants reside in include/linux/i2c.h.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-27  7:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-26 22:39 [PATCH] media: ddbridge: Remove unused class-based I2C autoprobing code Heiner Kallweit
2024-01-27  7:12 ` Wolfram Sang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox