[PATCH] MAINTAINERS: remove me as maintainer for I2C host drivers

[PATCH] MAINTAINERS: remove me as maintainer for I2C host drivers

[Wolfram Sang]

The number of I2C host controller drivers keeps increasing, and although
I had some success acquiring specific driver maintainers, my bandwidth
is by far not enough to act as a fallback for the rest of the drivers.
To reflect this status-quo in MAINTAINERS, add a seperate entry for I2C
host drivers, let the I2C list (= community) be the contact point, and
mark this section as "Odd fixes".

Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
---

Joe: my tests worked fine with the file patterns; yet I'd appreciate if you
had time to double check them. Thanks!

 MAINTAINERS | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 6d296bdce328..2f7ccdcf76f7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -6580,15 +6580,23 @@ W:	https://i2c.wiki.kernel.org/
 Q:	https://patchwork.ozlabs.org/project/linux-i2c/list/
 T:	git git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
 S:	Maintained
-F:	Documentation/devicetree/bindings/i2c/
+F:	Documentation/devicetree/bindings/i2c/i2c.txt
 F:	Documentation/i2c/
-F:	drivers/i2c/
-F:	drivers/i2c/*/
+F:	drivers/i2c/*
 F:	include/linux/i2c.h
 F:	include/linux/i2c-*.h
 F:	include/uapi/linux/i2c.h
 F:	include/uapi/linux/i2c-*.h
 
+I2C SUBSYSTEM DRIVERS
+L:	linux-i2c@vger.kernel.org
+W:	https://i2c.wiki.kernel.org/
+Q:	https://patchwork.ozlabs.org/project/linux-i2c/list/
+T:	git git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
+S:	Odd Fixes
+F:	Documentation/devicetree/bindings/i2c/
+F:	drivers/i2c/*/
+
 I2C-TAOS-EVM DRIVER
 M:	Jean Delvare <jdelvare@suse.com>
 L:	linux-i2c@vger.kernel.org
-- 
2.11.0

Re: [PATCH] MAINTAINERS: remove me as maintainer for I2C host drivers

[Joe Perches]

On Tue, 2018-04-10 at 16:11 +0200, Wolfram Sang wrote:
> The number of I2C host controller drivers keeps increasing, and although
> I had some success acquiring specific driver maintainers, my bandwidth
> is by far not enough to act as a fallback for the rest of the drivers.
> To reflect this status-quo in MAINTAINERS, add a seperate entry for I2C
> host drivers, let the I2C list (= community) be the contact point, and
> mark this section as "Odd fixes".
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> 
> Joe: my tests worked fine with the file patterns; yet I'd appreciate if you
> had time to double check them. Thanks!

Hi Wolfram.

As far as I understand, all this seems correct to me.

You want to maintain the core files in drivers/i2c/
but not any files in any of algos/, busses/, or muxes/.

You might also want to specify which of the
include/linux/i2c-*.h files you actually want to oversee
as well.  It seems some are driver specific.

But the git entry for the drivers seems maybe a bit of
an issue.  Are you
intending to somehow pick up patches
approved by the i2c community?  If
not, no worries I
guess, someone might come along to provide help.

cheers, Joe

>  MAINTAINERS | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6d296bdce328..2f7ccdcf76f7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6580,15 +6580,23 @@ W:	https://i2c.wiki.kernel.org/
>  Q:	https://patchwork.ozlabs.org/project/linux-i2c/list/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
>  S:	Maintained
> -F:	Documentation/devicetree/bindings/i2c/
> +F:	Documentation/devicetree/bindings/i2c/i2c.txt
>  F:	Documentation/i2c/
> -F:	drivers/i2c/
> -F:	drivers/i2c/*/
> +F:	drivers/i2c/*
>  F:	include/linux/i2c.h
>  F:	include/linux/i2c-*.h
>  F:	include/uapi/linux/i2c.h
>  F:	include/uapi/linux/i2c-*.h
>  
> +I2C SUBSYSTEM DRIVERS
> +L:	linux-i2c@vger.kernel.org
> +W:	https://i2c.wiki.kernel.org/
> +Q:	https://patchwork.ozlabs.org/project/linux-i2c/list/
> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
> +S:	Odd Fixes
> +F:	Documentation/devicetree/bindings/i2c/
> +F:	drivers/i2c/*/
> +
>  I2C-TAOS-EVM DRIVER
>  M:	Jean Delvare <jdelvare@suse.com>
>  L:	linux-i2c@vger.kernel.org

Re: [PATCH] MAINTAINERS: remove me as maintainer for I2C host drivers

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 952 bytes --]


> As far as I understand, all this seems correct to me.

Good. Thank you, Joe!

> You want to maintain the core files in drivers/i2c/
> but not any files in any of algos/, busses/, or muxes/.

More specific: I don't want get_maintainer.pl to print me as a
maintainer for these drivers. This gives a wrong impression to users. I
am not actively maintaining these drivers, I am collecting the odd
fixes (and also review some of them as time permits).

> You might also want to specify which of the
> include/linux/i2c-*.h files you actually want to oversee
> as well.  It seems some are driver specific.

I am just now working on that. Most of them can easily be moved to
platform_data.

> But the git entry for the drivers seems maybe a bit of an issue.  Are
> you intending to somehow pick up patches approved by the i2c
> community?

Yes, I will still be doing that. I think I will also be the one doing
most review for those odd fixes nonetheless.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] MAINTAINERS: remove me as maintainer for I2C host drivers

[Joe Perches]

On Tue, 2018-04-10 at 16:46 +0200, Wolfram Sang wrote:
> > As far as I understand, all this seems correct to me.
> 
> Good. Thank you, Joe!
> /
> > You want to maintain the core files in drivers/i2c/
> > but not any files in any of algos/, busses/, or muxes/.
> 
> More specific: I don't want get_maintainer.pl to print me as a
> maintainer for these drivers.

I believe get_maintainer.pl is still going to do that for
awhile as you are a commit signer for several of these driver
files.  Files that are not either "supported" or "maintained"
by default add the --git-fallback option.

For instance, With your patch:
$ ./scripts/get_maintainer.pl -f drivers/i2c/algos/i2c-algo-bit.c
Wolfram Sang <wsa+renesas@sang-engineering.com> (commit_signer:3/2=100%,authored:1/2=50%,added_lines:5/15=33%)
Jean Delvare <jdelvare@suse.de> (commit_signer:1/2=50%,authored:1/2=50%,added_lines:10/15=67%,removed_lines:3/3=100%)
linux-i2c@vger.kernel.org (open list:I2C SUBSYSTEM DRIVERS)
linux-kernel@vger.kernel.org (open list)

Your name should not be shown after a year or so unless you
actually sign-off on patches to those subdirectories.

btw: You signed-off using 2 different addresses on one
of those patches.  I think that's odd.

commit 3e5f06bed72fe72166a6778f630241a893f67799
Author: Wolfram Sang <wsa+renesas@sang-engineering.com>
Date:   Mon Dec 4 09:16:18 2017 +0100

    i2c: algo-bit: init the bus to a known state
    
    Ensure the bus is free when we register the adapter. Before the SCL/SDA
    wires were in an unknown state. It used to work because sending a byte
    has a retry mechanism which was triggered if the bus was initially in a
    non-free state. But the graceful way to do it is to initialize
    correctly.
    
    Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
    Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

Re: [PATCH] MAINTAINERS: remove me as maintainer for I2C host drivers

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 589 bytes --]


> I believe get_maintainer.pl is still going to do that for
> awhile as you are a commit signer for several of these driver
> files.

Okay, I forgot that I use "--no-git" in the config file. Still, while
not perfect, it is one step better.

> btw: You signed-off using 2 different addresses on one
> of those patches.  I think that's odd.
...
>     Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

I created this patch during work time.

>     Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

But I applied it in my spare time.

I didn't find a better way to encode that.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] MAINTAINERS: remove me as maintainer for I2C host drivers

[Peter Rosin]

On 2018-04-10 16:11, Wolfram Sang wrote:
> The number of I2C host controller drivers keeps increasing, and although
> I had some success acquiring specific driver maintainers, my bandwidth
> is by far not enough to act as a fallback for the rest of the drivers.
> To reflect this status-quo in MAINTAINERS, add a seperate entry for I2C
> host drivers, let the I2C list (= community) be the contact point, and
> mark this section as "Odd fixes".
> 
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> 
> Joe: my tests worked fine with the file patterns; yet I'd appreciate if you
> had time to double check them. Thanks!
> 
>  MAINTAINERS | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 6d296bdce328..2f7ccdcf76f7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6580,15 +6580,23 @@ W:	https://i2c.wiki.kernel.org/
>  Q:	https://patchwork.ozlabs.org/project/linux-i2c/list/
>  T:	git git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
>  S:	Maintained
> -F:	Documentation/devicetree/bindings/i2c/
> +F:	Documentation/devicetree/bindings/i2c/i2c.txt
>  F:	Documentation/i2c/
> -F:	drivers/i2c/
> -F:	drivers/i2c/*/
> +F:	drivers/i2c/*
>  F:	include/linux/i2c.h
>  F:	include/linux/i2c-*.h
>  F:	include/uapi/linux/i2c.h
>  F:	include/uapi/linux/i2c-*.h

Hmm, I think you are ducking out from the i2c-mux-pinctrl driver as well.
Was that the intent?

> +I2C SUBSYSTEM DRIVERS
> +L:	linux-i2c@vger.kernel.org
> +W:	https://i2c.wiki.kernel.org/
> +Q:	https://patchwork.ozlabs.org/project/linux-i2c/list/
> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
> +S:	Odd Fixes
> +F:	Documentation/devicetree/bindings/i2c/
> +F:	drivers/i2c/*/
> +

And this includes all the other muxes, i.e. those that are "mine". Maybe
not a problem, but what do I know?

Cheers,
Peter

>  I2C-TAOS-EVM DRIVER
>  M:	Jean Delvare <jdelvare@suse.com>
>  L:	linux-i2c@vger.kernel.org
> 

Re: [PATCH] MAINTAINERS: remove me as maintainer for I2C host drivers

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]

Hi Peter,

> Hmm, I think you are ducking out from the i2c-mux-pinctrl driver as well.
> Was that the intent?

Oops, nope! Sorry, I just forgot about the demux (I think you mean that
one) driver and will create a seperate entry for it.

> 
> > +I2C SUBSYSTEM DRIVERS
> > +L:	linux-i2c@vger.kernel.org
> > +W:	https://i2c.wiki.kernel.org/
> > +Q:	https://patchwork.ozlabs.org/project/linux-i2c/list/
> > +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
> > +S:	Odd Fixes
> > +F:	Documentation/devicetree/bindings/i2c/
> > +F:	drivers/i2c/*/
> > +
> 
> And this includes all the other muxes, i.e. those that are "mine". Maybe
> not a problem, but what do I know?

Sorry again, I really didn't want to dump something on you or leave you
all alone with the muxes. I was just so focussed on the host drivers
that muxes simply slipped through my mind :( I can add myself to the
muxes section again, no problem. I'll let you decidei what you prefer,
both is fine for me. You are doing a great job there!

Kind regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] MAINTAINERS: remove me as maintainer for I2C host drivers

[Peter Rosin]

On 2018-04-10 17:52, Wolfram Sang wrote:
> Hi Peter,
> 
>> Hmm, I think you are ducking out from the i2c-mux-pinctrl driver as well.
>> Was that the intent?
> 
> Oops, nope! Sorry, I just forgot about the demux (I think you mean that
> one) driver and will create a seperate entry for it.

Right, I meant the demux...

>>
>>> +I2C SUBSYSTEM DRIVERS
>>> +L:	linux-i2c@vger.kernel.org
>>> +W:	https://i2c.wiki.kernel.org/
>>> +Q:	https://patchwork.ozlabs.org/project/linux-i2c/list/
>>> +T:	git git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git
>>> +S:	Odd Fixes
>>> +F:	Documentation/devicetree/bindings/i2c/
>>> +F:	drivers/i2c/*/
>>> +
>>
>> And this includes all the other muxes, i.e. those that are "mine". Maybe
>> not a problem, but what do I know?
> 
> Sorry again, I really didn't want to dump something on you or leave you
> all alone with the muxes. I was just so focussed on the host drivers
> that muxes simply slipped through my mind :( I can add myself to the
> muxes section again, no problem. I'll let you decidei what you prefer,
> both is fine for me. You are doing a great job there!

No no, you don't need to add yourself there. I understand the mux drivers,
and it's pretty quiet, so no need for that. What I was worrying about was
this "Odd Fixes" fallback entry needlessly covering the muxes when they
are covered elsewhere.

Cheers,
Peter