From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Cezar Chiru <chiru.cezar.89@gmail.com>
Cc: andi.shyti@kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c : i2c-algo-pcf : fixed errors and warnings in header file
Date: Thu, 25 Sep 2025 12:42:39 +0200 [thread overview]
Message-ID: <aNUcn7TxcnwG0OLw@shikoro> (raw)
In-Reply-To: <20250907090344.30917-1-chiru.cezar.89@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
On Sun, Sep 07, 2025 at 12:03:44PM +0300, Cezar Chiru wrote:
> Fixed code indent should use tabs error, missing '*' from
> multiple line block comment warning, space prohibited after
> paranthesis error and no space before tabs warning.
> My motivation was to fix all errors and warnings in
> drivers/i2c/algos/i2c-algo-pcf.h file.
>
> Testing:
> * built kernel with my changes and I2C_ALGOPCF=m enabled
> and it built successfully.
> * installed kernel and external modules generated by build
> * rebooted and loaded using modprobe i2c-algo-pcf kernel module
> with param i2c_debug=3 and no message was found related to
> module in dmesg. But also no error was generated.
Because these are only whitespace changes, the object file (.o) should
not have change after your change. You can check for that.
> -#define I2C_PCF_REPSTART ( I2C_PCF_ESO | I2C_PCF_STA | I2C_PCF_ACK)
> +#define I2C_PCF_REPSTART (I2C_PCF_ESO | I2C_PCF_STA | I2C_PCF_ACK)
checkpatch is wrong here, this is less readable than before.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2025-09-25 10:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-07 9:03 [PATCH] i2c : i2c-algo-pcf : fixed errors and warnings in header file Cezar Chiru
2025-09-25 10:42 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aNUcn7TxcnwG0OLw@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=chiru.cezar.89@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox