[PATCH] i2c : i2c-algo-pcf : fixed errors and warnings in header file

[PATCH] i2c : i2c-algo-pcf : fixed errors and warnings in header file

[Cezar Chiru]

Fixed code indent should use tabs error, missing '*' from
multiple line block comment warning, space prohibited after
paranthesis error and no space before tabs warning.
My motivation was to fix all errors and warnings in
drivers/i2c/algos/i2c-algo-pcf.h file.

Testing:
    * built kernel with my changes and I2C_ALGOPCF=m enabled
    and it built successfully.
    * installed kernel and external modules generated by build
    * rebooted and loaded using modprobe i2c-algo-pcf kernel module
    with param i2c_debug=3 and no message was found related to
    module in dmesg. But also no error was generated.

Signed-off-by: Cezar Chiru <chiru.cezar.89@gmail.com>
---
 drivers/i2c/algos/i2c-algo-pcf.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/i2c/algos/i2c-algo-pcf.h b/drivers/i2c/algos/i2c-algo-pcf.h
index 2448ab192ce5..d9393092aaf1 100644
--- a/drivers/i2c/algos/i2c-algo-pcf.h
+++ b/drivers/i2c/algos/i2c-algo-pcf.h
@@ -3,8 +3,8 @@
 /* i2c-pcf8584.h: PCF 8584 global defines				*/
 /* -------------------------------------------------------------------- */
 /*   Copyright (C) 1996 Simon G. Vogl
-                   1999 Hans Berglund
-
+ *		   1999 Hans Berglund
+ *
  */
 /* --------------------------------------------------------------------	*/
 
@@ -25,7 +25,7 @@
 
 #define I2C_PCF_START    (I2C_PCF_PIN | I2C_PCF_ESO | I2C_PCF_STA | I2C_PCF_ACK)
 #define I2C_PCF_STOP     (I2C_PCF_PIN | I2C_PCF_ESO | I2C_PCF_STO | I2C_PCF_ACK)
-#define I2C_PCF_REPSTART (              I2C_PCF_ESO | I2C_PCF_STA | I2C_PCF_ACK)
+#define I2C_PCF_REPSTART	       (I2C_PCF_ESO | I2C_PCF_STA | I2C_PCF_ACK)
 #define I2C_PCF_IDLE     (I2C_PCF_PIN | I2C_PCF_ESO               | I2C_PCF_ACK)
 
 /* ----- Status register bits -----------------------------------------	*/
@@ -55,7 +55,7 @@
 
 
 /* ----- Access to internal registers according to ES1,ES2 ------------	*/
-/* they are mapped to the data port ( a0 = 0 ) 				*/
+/* they are mapped to the data port ( a0 = 0 )				*/
 /* available when ESO == 0 :						*/
 
 #define I2C_PCF_OWNADR	0
-- 
2.43.0

Re: [PATCH] i2c : i2c-algo-pcf : fixed errors and warnings in header file

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

On Sun, Sep 07, 2025 at 12:03:44PM +0300, Cezar Chiru wrote:
> Fixed code indent should use tabs error, missing '*' from
> multiple line block comment warning, space prohibited after
> paranthesis error and no space before tabs warning.
> My motivation was to fix all errors and warnings in
> drivers/i2c/algos/i2c-algo-pcf.h file.
> 
> Testing:
>     * built kernel with my changes and I2C_ALGOPCF=m enabled
>     and it built successfully.
>     * installed kernel and external modules generated by build
>     * rebooted and loaded using modprobe i2c-algo-pcf kernel module
>     with param i2c_debug=3 and no message was found related to
>     module in dmesg. But also no error was generated.

Because these are only whitespace changes, the object file (.o) should
not have change after your change. You can check for that.

> -#define I2C_PCF_REPSTART (              I2C_PCF_ESO | I2C_PCF_STA | I2C_PCF_ACK)
> +#define I2C_PCF_REPSTART	       (I2C_PCF_ESO | I2C_PCF_STA | I2C_PCF_ACK)

checkpatch is wrong here, this is less readable than before.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]