* [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue
@ 2024-10-29 11:14 Liam Zuiderhoek
2024-11-14 9:54 ` Wolfram Sang
0 siblings, 1 reply; 5+ messages in thread
From: Liam Zuiderhoek @ 2024-10-29 11:14 UTC (permalink / raw)
To: wsa+renesas; +Cc: linux-i2c, linux-kernel
From 214adebf7cf37be941f208124fac9ea6bec0f1d2 Mon Sep 17 00:00:00 2001
From: Liam Zuiderhoek <zuiderhoekl@gmail.com>
Date: Tue, 22 Oct 2024 20:46:59 +0200
Subject: [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue
Fixing a coding style issue.
Signed-off-by: Liam Zuiderhoek <zuiderhoekl@gmail.com>
---
drivers/i2c/i2c-core-smbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-
smbus.c
index e3b96fc53b5c..6829def15933 100644
--- a/drivers/i2c/i2c-core-smbus.c
+++ b/drivers/i2c/i2c-core-smbus.c
@@ -122,7 +122,7 @@ EXPORT_SYMBOL(i2c_smbus_read_byte);
s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value)
{
return i2c_smbus_xfer(client->adapter, client->addr, client-
>flags,
- I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE,
NULL);
+ I2C_SMBUS_WRITE, value,
I2C_SMBUS_BYTE, NULL);
}
EXPORT_SYMBOL(i2c_smbus_write_byte);
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue
2024-10-29 11:14 [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue Liam Zuiderhoek
@ 2024-11-14 9:54 ` Wolfram Sang
0 siblings, 0 replies; 5+ messages in thread
From: Wolfram Sang @ 2024-11-14 9:54 UTC (permalink / raw)
To: Liam Zuiderhoek; +Cc: linux-i2c, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]
On Tue, Oct 29, 2024 at 12:14:54PM +0100, Liam Zuiderhoek wrote:
> From 214adebf7cf37be941f208124fac9ea6bec0f1d2 Mon Sep 17 00:00:00 2001
> From: Liam Zuiderhoek <zuiderhoekl@gmail.com>
> Date: Tue, 22 Oct 2024 20:46:59 +0200
> Subject: [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue
>
> Fixing a coding style issue.
>
> Signed-off-by: Liam Zuiderhoek <zuiderhoekl@gmail.com>
> ---
> drivers/i2c/i2c-core-smbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-
> smbus.c
> index e3b96fc53b5c..6829def15933 100644
> --- a/drivers/i2c/i2c-core-smbus.c
> +++ b/drivers/i2c/i2c-core-smbus.c
> @@ -122,7 +122,7 @@ EXPORT_SYMBOL(i2c_smbus_read_byte);
> s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value)
> {
> return i2c_smbus_xfer(client->adapter, client->addr, client-
> >flags,
> - I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE,
> NULL);
> + I2C_SMBUS_WRITE, value,
> I2C_SMBUS_BYTE, NULL);
> }
> EXPORT_SYMBOL(i2c_smbus_write_byte);
The patch got broken while sending. I assume you sent it via gmail
webmail? Please read Documentation/process/email-clients.rst to make
sure it arrives correctly.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue
@ 2024-11-14 16:50 Liam Zuiderhoek
2024-11-19 19:51 ` Andi Shyti
0 siblings, 1 reply; 5+ messages in thread
From: Liam Zuiderhoek @ 2024-11-14 16:50 UTC (permalink / raw)
To: wsa+renesas; +Cc: linux-i2c, linux-kernel
From 214adebf7cf37be941f208124fac9ea6bec0f1d2 Mon Sep 17 00:00:00 2001
From: Liam Zuiderhoek <zuiderhoekl@gmail.com>
Date: Tue, 22 Oct 2024 20:46:59 +0200
Subject: [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue
Fixing a coding style issue.
Signed-off-by: Liam Zuiderhoek <zuiderhoekl@gmail.com>
---
drivers/i2c/i2c-core-smbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-smbus.c
index e3b96fc53b5c..6829def15933 100644
--- a/drivers/i2c/i2c-core-smbus.c
+++ b/drivers/i2c/i2c-core-smbus.c
@@ -122,7 +122,7 @@ EXPORT_SYMBOL(i2c_smbus_read_byte);
s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value)
{
return i2c_smbus_xfer(client->adapter, client->addr, client->flags,
- I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL);
+ I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL);
}
EXPORT_SYMBOL(i2c_smbus_write_byte);
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue
2024-11-14 16:50 Liam Zuiderhoek
@ 2024-11-19 19:51 ` Andi Shyti
0 siblings, 0 replies; 5+ messages in thread
From: Andi Shyti @ 2024-11-19 19:51 UTC (permalink / raw)
To: Liam Zuiderhoek; +Cc: wsa+renesas, linux-i2c, linux-kernel
Hi Liam,
your patch is almost correct, just a few things need to be fixed.
On Thu, Nov 14, 2024 at 05:50:06PM +0100, Liam Zuiderhoek wrote:
> From 214adebf7cf37be941f208124fac9ea6bec0f1d2 Mon Sep 17 00:00:00 2001
> From: Liam Zuiderhoek <zuiderhoekl@gmail.com>
> Date: Tue, 22 Oct 2024 20:46:59 +0200
> Subject: [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue
Why the header file is in the commit log?
The title needs to be written in imperative form:
"Fix whitespace style issue"
instead of
"fixed a whitespace..."
> Fixing a coding style issue.
We have plenty of space in the commit log and you can be more
specific on the coding style you are fixing; e.g. "use tabs
instead of white spaces for alignment".
Please read Documentation/process/submitting-patches.rst.
> Signed-off-by: Liam Zuiderhoek <zuiderhoekl@gmail.com>
> ---
> drivers/i2c/i2c-core-smbus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-smbus.c
> index e3b96fc53b5c..6829def15933 100644
> --- a/drivers/i2c/i2c-core-smbus.c
> +++ b/drivers/i2c/i2c-core-smbus.c
> @@ -122,7 +122,7 @@ EXPORT_SYMBOL(i2c_smbus_read_byte);
> s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value)
> {
> return i2c_smbus_xfer(client->adapter, client->addr, client->flags,
> - I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL);
> + I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL);
Please align everything under the "(":
return i2c_smbus_xfer(client->adapter, client->addr, client->flags,
I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE, NULL);
That means, use as many tabs as you can, until you need to use
spaces to align under the "(".
Thanks,
Andi
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue
@ 2024-10-22 19:05 Liam Zuiderhoek
0 siblings, 0 replies; 5+ messages in thread
From: Liam Zuiderhoek @ 2024-10-22 19:05 UTC (permalink / raw)
To: wsa+renesas; +Cc: linux-i2c, linux-kernel
From 214adebf7cf37be941f208124fac9ea6bec0f1d2 Mon Sep 17 00:00:00 2001
From: Liam Zuiderhoek <zuiderhoekl@gmail.com>
Date: Tue, 22 Oct 2024 20:46:59 +0200
Subject: [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue
Fixing a coding style issue.
Signed-off-by: Liam Zuiderhoek <zuiderhoekl@gmail.com>
---
drivers/i2c/i2c-core-smbus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i2c/i2c-core-smbus.c b/drivers/i2c/i2c-core-
smbus.c
index e3b96fc53b5c..6829def15933 100644
--- a/drivers/i2c/i2c-core-smbus.c
+++ b/drivers/i2c/i2c-core-smbus.c
@@ -122,7 +122,7 @@ EXPORT_SYMBOL(i2c_smbus_read_byte);
s32 i2c_smbus_write_byte(const struct i2c_client *client, u8 value)
{
return i2c_smbus_xfer(client->adapter, client->addr, client-
>flags,
- I2C_SMBUS_WRITE, value, I2C_SMBUS_BYTE,
NULL);
+ I2C_SMBUS_WRITE, value,
I2C_SMBUS_BYTE, NULL);
}
EXPORT_SYMBOL(i2c_smbus_write_byte);
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-11-19 19:51 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-29 11:14 [PATCH] i2c: i2c-core-smbus: fixed a whitespace style issue Liam Zuiderhoek
2024-11-14 9:54 ` Wolfram Sang
-- strict thread matches above, loose matches on Subject: below --
2024-11-14 16:50 Liam Zuiderhoek
2024-11-19 19:51 ` Andi Shyti
2024-10-22 19:05 Liam Zuiderhoek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox