[PATCH] i2c: busses: i2c-qcom-geni: Use resume and get pm runtime interface

[PATCH] i2c: busses: i2c-qcom-geni: Use resume and get pm runtime interface

[Alex Tran]

Utilize the provided pm_runtime_resume_and_get api
to increase the usage count and call the rpm resume
callback. Upon failure, the function takes care of
calling pm_runtime_put_noidle. Remove the explicit
call to put no idle.

Signed-off-by: Alex Tran <alex.tran@oss.qualcomm.com>
---
 drivers/i2c/busses/i2c-qcom-geni.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/i2c/busses/i2c-qcom-geni.c b/drivers/i2c/busses/i2c-qcom-geni.c
index 658636c1ee0e..d5f4de3e0a9d 100644
--- a/drivers/i2c/busses/i2c-qcom-geni.c
+++ b/drivers/i2c/busses/i2c-qcom-geni.c
@@ -963,10 +963,9 @@ static int geni_i2c_xfer(struct i2c_adapter *adap,
 	struct geni_i2c_dev *gi2c = i2c_get_adapdata(adap);
 	int ret;
 
-	ret = pm_runtime_get_sync(gi2c->se.dev);
+	ret = pm_runtime_resume_and_get(gi2c->se.dev);
 	if (ret < 0) {
 		dev_err(gi2c->se.dev, "error turning SE resources:%d\n", ret);
-		pm_runtime_put_noidle(gi2c->se.dev);
 		/* Set device in suspended since resume failed */
 		pm_runtime_set_suspended(gi2c->se.dev);
 		return ret;

---
base-commit: 45c13f3f9e3bb15fd89ff2864c6f627a3b4b4229
change-id: 20260825-i2c-qcom-geni-pm-runtime-resume-get-ddfbcee1a63d

Best regards,
--  
Alex Tran <alex.tran@oss.qualcomm.com>

Re: [PATCH] i2c: busses: i2c-qcom-geni: Use resume and get pm runtime interface

[Mukesh Savaliya]

On 8/26/2026 10:49 PM, Alex Tran wrote:
> Utilize the provided pm_runtime_resume_and_get api
> to increase the usage count and call the rpm resume
> callback. Upon failure, the function takes care of
> calling pm_runtime_put_noidle. Remove the explicit
> call to put no idle.
> 

No functional change added.

> Signed-off-by: Alex Tran <alex.tran@oss.qualcomm.com>
> ---

Reviewed-by: Mukesh Kumar Savaliya <mukesh.savaliya@oss.qualcomm.com>

Re: [PATCH] i2c: busses: i2c-qcom-geni: Use resume and get pm runtime interface

[Andi Shyti]

Hi Alex,

I reworded a bit the title to:

i2c: busses: Use pm_runtime_resume_and_get()

It's more understandable.

On Wed, Aug 26, 2026 at 10:19:26AM -0700, Alex Tran wrote:
> Utilize the provided pm_runtime_resume_and_get api
> to increase the usage count and call the rpm resume
> callback. Upon failure, the function takes care of
> calling pm_runtime_put_noidle. Remove the explicit
> call to put no idle.

I added here Mukesh' suggestion.

> Signed-off-by: Alex Tran <alex.tran@oss.qualcomm.com>

Merged to i2c/i2c.

Thanks,
Andi