Re: [PATCH 1/3] i2c: ibm_iic: ioremap with platform pointer

[Andi Shyti <andi.shyti@kernel.org>]

Hi Rosen,

On Fri, Aug 21, 2026 at 04:02:14PM -0700, Rosen Penev wrote:
> devm_platform_ioremap_resource only needs a platform_device pointer and
> calling it early allows handling potential -EPROBE_DEFER.

Please improve the commit message as suggested by Markus. Please
use the imperative form, it's not just a formality, but it helps
understand what you actually did (I'm using the imperative form
here sothat you clearly understand me).

Besides devm_platform_ioremap_resource() does not return
EPROBE_DEFER.

> Signed-off-by: Rosen Penev <rosenp@gmail.com>

...

> @@ -751,9 +751,6 @@ static int iic_probe(struct platform_device *ofdev)
>  		free_irq(dev->irq, dev);
>  	}
>  
> -	if (dev->vaddr)
> -		iounmap(dev->vaddr);

I think now you can remove linux/of_address.h

Thanks,
Andi

> -
>  	kfree(dev);
>  	return ret;
>  }
> @@ -772,7 +769,6 @@ static void iic_remove(struct platform_device *ofdev)
>  		free_irq(dev->irq, dev);
>  	}
>  
> -	iounmap(dev->vaddr);
>  	kfree(dev);
>  }
>  
> -- 
> 2.55.0
>