From: Krzysztof Kozlowski <krzk@kernel.org>
To: Andi Shyti <andi.shyti@kernel.org>, Wang Ming <machel@vivo.com>
Cc: Peter Korsgaard <peter.korsgaard@barco.com>,
Peter Rosin <peda@axentia.se>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v1] drivers/i2c/muxes:Fix resource leaks in device_for_each_child_node() loops
Date: Wed, 14 Jun 2023 14:02:13 +0200 [thread overview]
Message-ID: <bc8a4601-2651-cd69-42d2-f34992f797eb@kernel.org> (raw)
In-Reply-To: <20230614114339.zhuhij6vobdnbse5@intel.intel>
On 14/06/2023 13:43, Andi Shyti wrote:
> Hi Wang,
>
>> diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c
>> index 5d5cbe013..90966de7a 100644
>> --- a/drivers/i2c/muxes/i2c-mux-gpio.c
>> +++ b/drivers/i2c/muxes/i2c-mux-gpio.c
>> @@ -106,6 +106,7 @@ static int i2c_mux_gpio_probe_fw(struct gpiomux *mux,
>> } else if (is_acpi_node(child)) {
>> rc = acpi_get_local_address(ACPI_HANDLE_FWNODE(child), values + i);
>> if (rc)
>> + fwnode_handle_put(child);
>> return dev_err_probe(dev, rc, "Cannot get address\n");
>> }
>
> please, read it again and tell me what's wrong :)
No, we can't tell what's wrong because:
> The contents of this message and any attachments may contain
> confidential and/or privileged information
:)
Wang,
Just run the sparse and smatch before posting patches.
Best regards,
Krzysztof
prev parent reply other threads:[~2023-06-14 12:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-14 11:28 [PATCH v1] drivers/i2c/muxes:Fix resource leaks in device_for_each_child_node() loops Wang Ming
2023-06-14 11:43 ` Andi Shyti
2023-06-14 12:02 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc8a4601-2651-cd69-42d2-f34992f797eb@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=machel@vivo.com \
--cc=opensource.kernel@vivo.com \
--cc=peda@axentia.se \
--cc=peter.korsgaard@barco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox