From: Rong Qianfeng <11065417@vivo.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Rong Qianfeng <rongqianfeng@vivo.com>,
biju.das.jz@bp.renesas.com,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andi Shyti <andi.shyti@kernel.org>,
Paul Cercueil <paul@crapouillou.net>,
linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org,
opensource.kernel@vivo.com
Subject: Re: [PATCH v3 3/4] i2c: jz4780: Use devm_clk_get_enabled() helpers
Date: Mon, 26 Aug 2024 19:56:20 +0800 [thread overview]
Message-ID: <c253ff51-52bd-446a-aab4-274f55a4b80c@vivo.com> (raw)
In-Reply-To: <ZsxaEtWEMWeoVusv@smile.fi.intel.com>
在 2024/8/26 18:33, Andy Shevchenko 写道:
> On Mon, Aug 26, 2024 at 11:03:20AM +0800, Rong Qianfeng wrote:
>> 在 2024/8/23 23:33, Andy Shevchenko 写道:
>>> On Fri, Aug 23, 2024 at 11:51:15AM +0800, Rong Qianfeng wrote:
> ...
>
>>>> ret = of_property_read_u32(pdev->dev.of_node, "clock-frequency",
>>>> &clk_freq);
>>> (side note: this driver should use i2c_timings and respective I2C core
>>> APIs instead of this)
>> Sorry, I didn't fully understand what you meant, it's my problem. I guess
>> you are suggesting to use an API like i2c_parse_fw_timings() to get the
>> clock-frequency?
> Yes.
Very good point, Thanks for letting me know about these advanced APIs.
I think we may need some other patch series to discuss how to implement it,
because there are many places in the i2c that need such modifications, and
these modifications are not suitable in the current patch series.
>
next prev parent reply other threads:[~2024-08-26 11:56 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 3:51 [PATCH v3 0/4] i2c: Use devm_clk_get_enabled() helpers Rong Qianfeng
2024-08-23 3:51 ` [PATCH v3 1/4] i2c: emev2: " Rong Qianfeng
2024-08-23 15:30 ` Andy Shevchenko
2024-08-23 3:51 ` [PATCH v3 2/4] i2c: emev2: drop sclk from struct em_i2c_device Rong Qianfeng
2024-08-26 9:09 ` Wolfram Sang
2024-08-26 9:29 ` Rong Qianfeng
2024-08-23 3:51 ` [PATCH v3 3/4] i2c: jz4780: Use devm_clk_get_enabled() helpers Rong Qianfeng
2024-08-23 15:33 ` Andy Shevchenko
2024-08-26 3:03 ` Rong Qianfeng
2024-08-26 10:33 ` Andy Shevchenko
2024-08-26 11:56 ` Rong Qianfeng [this message]
2024-08-23 3:51 ` [PATCH v3 4/4] i2c: jz4780: Use dev_err_probe() Rong Qianfeng
2024-08-23 15:36 ` Andy Shevchenko
2024-08-26 1:55 ` Rong Qianfeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c253ff51-52bd-446a-aab4-274f55a4b80c@vivo.com \
--to=11065417@vivo.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=paul@crapouillou.net \
--cc=rongqianfeng@vivo.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox