Re: [PATCH 4/5] i2c: piix4: Adjust the SMBus debug message

[Shyam Sundar S K <Shyam-sundar.S-k@amd.com>]

Hi Andi,

On 9/4/2024 03:21, Andi Shyti wrote:
> Hi Shyam,
> 
>> @@ -1194,6 +1194,7 @@ static int piix4_add_adapter(struct pci_dev *dev, unsigned short smba,
>>  {
>>  	struct i2c_adapter *adap;
>>  	struct i2c_piix4_adapdata *adapdata;
>> +	char *node = "PIIX4";
> 
> please, make this const and initialize it...
> 
>>  	int retval;
>>  
>>  	adap = kzalloc(sizeof(*adap), GFP_KERNEL);
>> @@ -1213,6 +1214,7 @@ static int piix4_add_adapter(struct pci_dev *dev, unsigned short smba,
>>  		adap->algo = &piix4_smbus_algorithm_sb800;
>>  		break;
> 
> ... here.
> 
>>  	case SMBUS_ASF:
>> +		node = "ASF";
>>  		adap->algo = &sb800_asf_smbus_algorithm;
>>  		break;
> 
> shall we have a default case here? I thought checkpatch complains
> when no default is specified.

checkpatch does not complain about it. I have added a default case
based on your suggestion in v2. Kindly have a look.

Thanks,
Shyam

> 
> Thanks,
> Andi