From: Waqar Hameed <waqar.hameed@axis.com>
To: Peter Rosin <peda@lysator.liu.se>,
Andi Shyti <andi.shyti@kernel.org>,
Farouk Bouabid <farouk.bouabid@cherry.de>,
Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: <kernel@axis.com>, <linux-i2c@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH RESEND v2] i2c: mux-mule: Remove error print for devm_add_action_or_reset()
Date: Wed, 20 May 2026 16:59:19 +0200 [thread overview]
Message-ID: <pndfr3mnn3s.a.out@axis.com> (raw)
When `devm_add_action_or_reset()` fails, it is due to a failed memory
allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
anything when error is `-ENOMEM`. Therefore, remove the useless call to
`dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
return the value instead.
Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
Changes in v2:
* Split the patch to one seperate patch for each sub-system.
Link to v1: https://lore.kernel.org/all/pnd7c0s6ji2.fsf@axis.com/
Trying a resend since my last ping was unanswered [1]. All other patches
in the previous patch series v1 has been merged. I have added some more
people in the "To"-field in hope of a response this time.
[1] https://lore.kernel.org/lkml/pndldlij2va.a.out@axis.com/
drivers/i2c/muxes/i2c-mux-mule.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/i2c/muxes/i2c-mux-mule.c b/drivers/i2c/muxes/i2c-mux-mule.c
index d3b32b794172..14c7d3d86853 100644
--- a/drivers/i2c/muxes/i2c-mux-mule.c
+++ b/drivers/i2c/muxes/i2c-mux-mule.c
@@ -90,8 +90,7 @@ static int mule_i2c_mux_probe(struct platform_device *pdev)
ret = devm_add_action_or_reset(mux_dev, mule_i2c_mux_remove, muxc);
if (ret)
- return dev_err_probe(mux_dev, ret,
- "Failed to register mux remove\n");
+ return ret;
/* Create device adapters */
for_each_child_of_node_scoped(mux_dev->of_node, dev) {
base-commit: 27fa82620cbaa89a7fc11ac3057701d598813e87
--
2.43.0
reply other threads:[~2026-05-20 14:59 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=pndfr3mnn3s.a.out@axis.com \
--to=waqar.hameed@axis.com \
--cc=andi.shyti@kernel.org \
--cc=farouk.bouabid@cherry.de \
--cc=kernel@axis.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@lysator.liu.se \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox