Linux I2C development
 help / color / mirror / Atom feed
* [PATCH RESEND v2] i2c: mux-mule: Remove error print for devm_add_action_or_reset()
@ 2026-05-20 14:59 Waqar Hameed
  0 siblings, 0 replies; only message in thread
From: Waqar Hameed @ 2026-05-20 14:59 UTC (permalink / raw)
  To: Peter Rosin, Andi Shyti, Farouk Bouabid, Wolfram Sang
  Cc: kernel, linux-i2c, linux-kernel

When `devm_add_action_or_reset()` fails, it is due to a failed memory
allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
anything when error is `-ENOMEM`. Therefore, remove the useless call to
`dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
return the value instead.

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
---
Changes in v2:

* Split the patch to one seperate patch for each sub-system.

Link to v1: https://lore.kernel.org/all/pnd7c0s6ji2.fsf@axis.com/

Trying a resend since my last ping was unanswered [1]. All other patches
in the previous patch series v1 has been merged. I have added some more
people in the "To"-field in hope of a response this time.

[1] https://lore.kernel.org/lkml/pndldlij2va.a.out@axis.com/

 drivers/i2c/muxes/i2c-mux-mule.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/i2c/muxes/i2c-mux-mule.c b/drivers/i2c/muxes/i2c-mux-mule.c
index d3b32b794172..14c7d3d86853 100644
--- a/drivers/i2c/muxes/i2c-mux-mule.c
+++ b/drivers/i2c/muxes/i2c-mux-mule.c
@@ -90,8 +90,7 @@ static int mule_i2c_mux_probe(struct platform_device *pdev)
 
 	ret = devm_add_action_or_reset(mux_dev, mule_i2c_mux_remove, muxc);
 	if (ret)
-		return dev_err_probe(mux_dev, ret,
-				     "Failed to register mux remove\n");
+		return ret;
 
 	/* Create device adapters */
 	for_each_child_of_node_scoped(mux_dev->of_node, dev) {

base-commit: 27fa82620cbaa89a7fc11ac3057701d598813e87
-- 
2.43.0


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2026-05-20 14:59 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-20 14:59 [PATCH RESEND v2] i2c: mux-mule: Remove error print for devm_add_action_or_reset() Waqar Hameed

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox