From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Jeremy Kerr <jk@codeconstruct.com.au>
Cc: linux-i3c@lists.infradead.org,
Matt Johnston <matt@codeconstruct.com.au>,
Vitor Soares <ivitro@gmail.com>,
Jack Chen <zenghuchen@google.com>,
Billy Tsai <billy_tsai@aspeedtech.com>,
Dylan Hung <dylan_hung@aspeedtech.com>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH 0/5] i3c: dw,ast2600: Add In-Band Interrupt support
Date: Fri, 28 Apr 2023 08:51:37 +0200 [thread overview]
Message-ID: <20230428065137097609fa@mail.local> (raw)
In-Reply-To: <cda6874790ced41cbbeca5b5dbfe39be869fb2d4.camel@codeconstruct.com.au>
On 28/04/2023 08:01:39+0800, Jeremy Kerr wrote:
> Hi Aledandre,
>
> > I'm sorry about the late reply, I've been super busy this month. I'm
> > happy to take this series but it doesn't apply on top of v3 of your
> > other series. I guess this will have to wait for the next release.
>
> That was originally based on v3 - I think you've applied v2 of the
> ast2600 series.
>
> In:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/i3c/linux.git/commit/?id=7dcbb33d3b2b8bd903d3157fc7249a4cb4f6820d
>
> your linux-i3c tree has the v2 dw struct, with:
>
> + /* platform-specific data */
> + const struct dw_i3c_platform_ops *platform_ops;
> + void *platform_data;
> +};
>
> (platform_data was removed in v3).
>
> The Link: tag is correct though.
Indeed, I fixed that but this wasn't the issue. Patch 5/5 doesn't apply.
If you look at the context, it has "struct ast2600_i3c_platform_data {"
which is "struct ast2600_i3c {" in your v3. Also the chunk in
ast2600_i3c_probe() can't apply.
I fixed it up and pushed, please check.
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-04-28 6:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 7:50 [PATCH 0/5] i3c: dw,ast2600: Add In-Band Interrupt support Jeremy Kerr
2023-03-30 7:50 ` [PATCH 1/5] i3c: dw: Create a generic fifo read function Jeremy Kerr
2023-03-30 19:18 ` Ben Dooks
2023-03-31 2:16 ` Jeremy Kerr
2023-03-30 7:50 ` [PATCH 2/5] i3c: dw: Turn DAT array entry into a struct Jeremy Kerr
2023-03-30 7:50 ` [PATCH 3/5] i3c: dw: Add support for in-band interrupts Jeremy Kerr
2023-03-30 7:50 ` [PATCH 4/5] i3c: dw: Add a platform facility for IBI PEC workarounds Jeremy Kerr
2023-03-30 7:50 ` [PATCH 5/5] i3c: ast2600: enable IBI support Jeremy Kerr
2023-04-05 2:27 ` [PATCH 0/5] i3c: dw,ast2600: Add In-Band Interrupt support Joel Stanley
2023-04-27 22:35 ` Alexandre Belloni
2023-04-28 0:01 ` Jeremy Kerr
2023-04-28 6:51 ` Alexandre Belloni [this message]
2023-04-28 7:34 ` Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230428065137097609fa@mail.local \
--to=alexandre.belloni@bootlin.com \
--cc=andrew@aj.id.au \
--cc=billy_tsai@aspeedtech.com \
--cc=dylan_hung@aspeedtech.com \
--cc=ivitro@gmail.com \
--cc=jk@codeconstruct.com.au \
--cc=joel@jms.id.au \
--cc=linux-i3c@lists.infradead.org \
--cc=matt@codeconstruct.com.au \
--cc=zenghuchen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox