From: Jeremy Kerr <jk@codeconstruct.com.au>
To: Ben Dooks <ben.dooks@sifive.com>, linux-i3c@lists.infradead.org
Cc: Matt Johnston <matt@codeconstruct.com.au>,
Vitor Soares <ivitro@gmail.com>,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Jack Chen <zenghuchen@google.com>,
Billy Tsai <billy_tsai@aspeedtech.com>,
Dylan Hung <dylan_hung@aspeedtech.com>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>
Subject: Re: [PATCH 1/5] i3c: dw: Create a generic fifo read function
Date: Fri, 31 Mar 2023 10:16:01 +0800 [thread overview]
Message-ID: <84d0caac03c6ca8d0c3ee282dbee1c55500c50ab.camel@codeconstruct.com.au> (raw)
In-Reply-To: <1981d2b2-8082-ccba-5a41-7f2162410163@sifive.com>
Hi Ben,
> > +static void dw_i3c_master_read_rx_fifo(struct dw_i3c_master *master,
> > + u8 *bytes, int nbytes)
> > +{
> > + return dw_i3c_master_read_fifo(master, RX_TX_DATA_PORT, bytes, nbytes);
> > +}
> > +
>
> Might want to make it inline too.
The compiler will almost certainly work that out:
$ arm-linux-gnueabihf-objdump -t drivers/i3c/master/dw-i3c-master.o | grep fifo
00000b74 l F .text 000000a4 dw_i3c_master_read_fifo
- and I'd prefer to not override any compiler decision not to inline, if
that works out better in specific circumstances or with any future
changes.
Cheers,
Jeremy
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-03-31 2:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-30 7:50 [PATCH 0/5] i3c: dw,ast2600: Add In-Band Interrupt support Jeremy Kerr
2023-03-30 7:50 ` [PATCH 1/5] i3c: dw: Create a generic fifo read function Jeremy Kerr
2023-03-30 19:18 ` Ben Dooks
2023-03-31 2:16 ` Jeremy Kerr [this message]
2023-03-30 7:50 ` [PATCH 2/5] i3c: dw: Turn DAT array entry into a struct Jeremy Kerr
2023-03-30 7:50 ` [PATCH 3/5] i3c: dw: Add support for in-band interrupts Jeremy Kerr
2023-03-30 7:50 ` [PATCH 4/5] i3c: dw: Add a platform facility for IBI PEC workarounds Jeremy Kerr
2023-03-30 7:50 ` [PATCH 5/5] i3c: ast2600: enable IBI support Jeremy Kerr
2023-04-05 2:27 ` [PATCH 0/5] i3c: dw,ast2600: Add In-Band Interrupt support Joel Stanley
2023-04-27 22:35 ` Alexandre Belloni
2023-04-28 0:01 ` Jeremy Kerr
2023-04-28 6:51 ` Alexandre Belloni
2023-04-28 7:34 ` Jeremy Kerr
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84d0caac03c6ca8d0c3ee282dbee1c55500c50ab.camel@codeconstruct.com.au \
--to=jk@codeconstruct.com.au \
--cc=alexandre.belloni@bootlin.com \
--cc=andrew@aj.id.au \
--cc=ben.dooks@sifive.com \
--cc=billy_tsai@aspeedtech.com \
--cc=dylan_hung@aspeedtech.com \
--cc=ivitro@gmail.com \
--cc=joel@jms.id.au \
--cc=linux-i3c@lists.infradead.org \
--cc=matt@codeconstruct.com.au \
--cc=zenghuchen@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox