* [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure
@ 2023-08-02 10:09 Billy Tsai
2023-08-10 7:38 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Billy Tsai @ 2023-08-02 10:09 UTC (permalink / raw)
To: alexandre.belloni, billy_tsai, linux-i3c, linux-kernel
The exit criteria for the DAA should check if the data length is equal to
1, instead of checking if the response status is equal to 1.
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
index d97c3175e0e2..6a781f89b0e4 100644
--- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
+++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
@@ -339,7 +339,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
break;
}
if (RESP_STATUS(xfer[0].response) == RESP_ERR_NACK &&
- RESP_STATUS(xfer[0].response) == 1) {
+ RESP_DATA_LENGTH(xfer->response) == 1) {
ret = 0; /* no more devices to be assigned */
break;
}
--
2.25.1
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure
2023-08-02 10:09 Billy Tsai
@ 2023-08-10 7:38 ` Alexandre Belloni
0 siblings, 0 replies; 5+ messages in thread
From: Alexandre Belloni @ 2023-08-10 7:38 UTC (permalink / raw)
To: linux-i3c, linux-kernel, Billy Tsai
On Wed, 02 Aug 2023 18:09:09 +0800, Billy Tsai wrote:
> The exit criteria for the DAA should check if the data length is equal to
> 1, instead of checking if the response status is equal to 1.
>
>
Applied, thanks!
[1/1] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure
commit: cbf871e6d8ce23dd4d458d8b7ab9d4a267e7bc03
Best regards,
--
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure
@ 2024-08-23 6:25 Billy Tsai
2024-08-23 12:48 ` Jarkko Nikula
0 siblings, 1 reply; 5+ messages in thread
From: Billy Tsai @ 2024-08-23 6:25 UTC (permalink / raw)
To: alexandre.belloni, jarkko.nikula, billy_tsai, linux-i3c,
linux-kernel
The exit criteria for the DAA should check if the data length is equal to
1, instead of checking if the response status is equal to 1.
Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
---
drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
index d97c3175e0e2..6a781f89b0e4 100644
--- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
+++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
@@ -339,7 +339,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
break;
}
if (RESP_STATUS(xfer[0].response) == RESP_ERR_NACK &&
- RESP_STATUS(xfer[0].response) == 1) {
+ RESP_DATA_LENGTH(xfer->response) == 1) {
ret = 0; /* no more devices to be assigned */
break;
}
--
2.25.1
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure
2024-08-23 6:25 [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure Billy Tsai
@ 2024-08-23 12:48 ` Jarkko Nikula
2024-08-26 3:37 ` Billy Tsai
0 siblings, 1 reply; 5+ messages in thread
From: Jarkko Nikula @ 2024-08-23 12:48 UTC (permalink / raw)
To: Billy Tsai, alexandre.belloni, linux-i3c, linux-kernel
Hi
On 8/23/24 9:25 AM, Billy Tsai wrote:
> The exit criteria for the DAA should check if the data length is equal to
> 1, instead of checking if the response status is equal to 1.
>
> Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> ---
> drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> index d97c3175e0e2..6a781f89b0e4 100644
> --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> @@ -339,7 +339,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
> break;
> }
> if (RESP_STATUS(xfer[0].response) == RESP_ERR_NACK &&
> - RESP_STATUS(xfer[0].response) == 1) {
> + RESP_DATA_LENGTH(xfer->response) == 1) {
> ret = 0; /* no more devices to be assigned */
> break;
> }
Did you accidentally resend this from a local tree? Is this the same
than your commit cbf871e6d8ce ("i3c/master: cmd_v1: Fix the exit
criteria for the daa procedure")?
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure
2024-08-23 12:48 ` Jarkko Nikula
@ 2024-08-26 3:37 ` Billy Tsai
0 siblings, 0 replies; 5+ messages in thread
From: Billy Tsai @ 2024-08-26 3:37 UTC (permalink / raw)
To: Jarkko Nikula, alexandre.belloni@bootlin.com,
linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org
> > The exit criteria for the DAA should check if the data length is equal to
> > 1, instead of checking if the response status is equal to 1.
> >
> > Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com>
> > ---
> > drivers/i3c/master/mipi-i3c-hci/cmd_v1.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> > index d97c3175e0e2..6a781f89b0e4 100644
> > --- a/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> > +++ b/drivers/i3c/master/mipi-i3c-hci/cmd_v1.c
> > @@ -339,7 +339,7 @@ static int hci_cmd_v1_daa(struct i3c_hci *hci)
> > break;
> > }
> > if (RESP_STATUS(xfer[0].response) == RESP_ERR_NACK &&
> > - RESP_STATUS(xfer[0].response) == 1) {
> > + RESP_DATA_LENGTH(xfer->response) == 1) {
> > ret = 0; /* no more devices to be assigned */
> > break;
> > }
> Did you accidentally resend this from a local tree? Is this the same
> than your commit cbf871e6d8ce ("i3c/master: cmd_v1: Fix the exit
> criteria for the daa procedure")?
Sorry, I have re-sent the previous patch from my local machine.
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-08-26 3:37 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-23 6:25 [PATCH] i3c/master: cmd_v1: Fix the exit criteria for the daa procedure Billy Tsai
2024-08-23 12:48 ` Jarkko Nikula
2024-08-26 3:37 ` Billy Tsai
-- strict thread matches above, loose matches on Subject: below --
2023-08-02 10:09 Billy Tsai
2023-08-10 7:38 ` Alexandre Belloni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox