From: Frank Li <Frank.Li@nxp.com>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
Parshuram Thombare <pthombar@cadence.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Boris Brezillon <bbrezillon@kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Conor Culhane <conor.culhane@silvaco.com>
Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
imx@lists.linux.dev, Frank Li <Frank.Li@nxp.com>,
stable@kernel.org
Subject: [PATCH v4 05/11] i3c: master: Fix miss free init_dyn_addr at i3c_master_put_i3c_addrs()
Date: Thu, 29 Aug 2024 17:14:02 -0400 [thread overview]
Message-ID: <20240829-i3c_fix-v4-5-ebcbd5efceba@nxp.com> (raw)
In-Reply-To: <20240829-i3c_fix-v4-0-ebcbd5efceba@nxp.com>
if (dev->boardinfo && dev->boardinfo->init_dyn_addr)
^^^ here check "init_dyn_addr"
i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr, ...)
^^^^
free "dyn_addr"
Fix copy/paste error "dyn_addr" by replacing it with "init_dyn_addr".
Cc: stable@kernel.org
Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure")
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
change from v3 to v4
- mention copy/paste error
- Add Miquel's review tag
---
drivers/i3c/master.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c
index 7c8fc4378b979..e7cbfaf13b599 100644
--- a/drivers/i3c/master.c
+++ b/drivers/i3c/master.c
@@ -1467,7 +1467,7 @@ static void i3c_master_put_i3c_addrs(struct i3c_dev_desc *dev)
I3C_ADDR_SLOT_FREE);
if (dev->boardinfo && dev->boardinfo->init_dyn_addr)
- i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr,
+ i3c_bus_set_addr_slot_status(&master->bus, dev->boardinfo->init_dyn_addr,
I3C_ADDR_SLOT_FREE);
}
--
2.34.1
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2024-08-29 21:15 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-29 21:13 [PATCH v4 00/11] i3c: master: some fix and improvemnt for hotjoin Frank Li
2024-08-29 21:13 ` [PATCH v4 01/11] i3c: master: Remove i3c_dev_disable_ibi_locked(olddev) on device hotjoin Frank Li
2024-08-29 21:13 ` [PATCH v4 02/11] i3c: master: Replace hard code 2 with macro I3C_ADDR_SLOT_STATUS_BITS Frank Li
2024-08-29 21:14 ` [PATCH v4 03/11] i3c: master: Extend address status bit to 4 and add I3C_ADDR_SLOT_EXT_INIT Frank Li
2024-08-29 21:14 ` [PATCH v4 04/11] i3c: master: Fix dynamic address leak when 'assigned-address' is present Frank Li
2024-08-29 21:14 ` Frank Li [this message]
2024-08-29 21:14 ` [PATCH v4 06/11] i3c: master: svc: use repeat start when IBI WIN happens Frank Li
2024-08-29 21:14 ` [PATCH v4 07/11] i3c: master: svc: manually emit NACK/ACK for hotjoin Frank Li
2024-08-29 21:14 ` [PATCH v4 08/11] i3c: master: svc: need check IBIWON for dynamtica address assign Frank Li
2024-08-29 21:14 ` [PATCH v4 09/11] i3c: master: svc: use spin_lock_irqsave at svc_i3c_master_ibi_work() Frank Li
2024-08-29 21:14 ` [PATCH v4 10/11] i3c: master: svc: wait for Manual ACK/NACK Done before next step Frank Li
2024-08-29 21:14 ` [PATCH v4 11/11] i3c: master: svc: fix possible assignment of the same address to two devices Frank Li
2024-09-26 17:02 ` [PATCH v4 00/11] i3c: master: some fix and improvemnt for hotjoin Frank Li
2024-09-30 9:34 ` Miquel Raynal
2024-09-30 15:16 ` Frank Li
2024-10-01 17:17 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240829-i3c_fix-v4-5-ebcbd5efceba@nxp.com \
--to=frank.li@nxp.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=bbrezillon@kernel.org \
--cc=boris.brezillon@collabora.com \
--cc=conor.culhane@silvaco.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miquel.raynal@bootlin.com \
--cc=pthombar@cadence.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox