From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: David Laight <david.laight.linux@gmail.com>
Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-renesas-soc@vger.kernel.org,
Rasmus Villemoes <linux@rasmusvillemoes.dk>,
Alexandre Belloni <alexandre.belloni@bootlin.com>
Subject: Re: [PATCH RFT v2 4/5] i3c: mipi-i3c-hci: use get_parity8 helper instead of open coding it
Date: Fri, 3 Jan 2025 22:17:02 +0100 [thread overview]
Message-ID: <Z3hTzvxp-Hzqnlj0@ninjato> (raw)
In-Reply-To: <20250103134935.2a341ce0@pumpkin>
[-- Attachment #1.1: Type: text/plain, Size: 581 bytes --]
> > Right, this is why the arguments of the ternary operator above are
> > exchanged. The old function was basically 'is_odd'.
>
> Provided the high bit isn't already set - which it may not be.
Not here. Temporary I3C addresses are in the range 0-0x7f.
> add: 00010001 => xxxx0010 => xx10 => x1
> xor: 00010001 => xxxx0000 => 00xx => x0
This point goes to you :)
> I bet the target isn't checking...
Could be, I can't tell. I don't have this HW.
> So you might be fixing a bug.
Heh, which better argument could one have for a generic implementation.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 111 bytes --]
--
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2025-01-10 11:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-29 10:12 [PATCH RFT v2 0/5] i3c: introduce and use generic parity helper Wolfram Sang
2024-12-29 10:12 ` [PATCH RFT v2 1/5] bitops: add generic parity calculation for u8 Wolfram Sang
2024-12-29 11:11 ` David Laight
2025-01-02 8:55 ` Wolfram Sang
2024-12-29 10:12 ` [PATCH RFT v2 2/5] hwmon: (spd5118) Use generic parity calculation Wolfram Sang
2024-12-29 10:12 ` [PATCH RFT v2 3/5] i3c: dw: use get_parity8 helper instead of open coding it Wolfram Sang
2024-12-29 10:12 ` [PATCH RFT v2 4/5] i3c: mipi-i3c-hci: " Wolfram Sang
2025-01-01 12:14 ` David Laight
2025-01-02 9:01 ` Wolfram Sang
2025-01-02 18:51 ` David Laight
2025-01-03 10:02 ` Wolfram Sang
2025-01-03 13:49 ` David Laight
2025-01-03 21:17 ` Wolfram Sang [this message]
2025-01-02 14:19 ` Jarkko Nikula
2025-01-02 14:46 ` Wolfram Sang
2024-12-29 10:12 ` [PATCH RFT v2 5/5] i3c: cdns: " Wolfram Sang
2024-12-29 10:49 ` Geert Uytterhoeven
2024-12-29 11:33 ` David Laight
2025-01-02 9:04 ` Wolfram Sang
2025-01-02 9:28 ` Geert Uytterhoeven
2025-01-02 9:34 ` Wolfram Sang
2025-01-03 22:08 ` Alexandre Belloni
2025-01-03 22:11 ` [PATCH RFT v2 0/5] i3c: introduce and use generic parity helper Alexandre Belloni
2025-01-03 22:16 ` Wolfram Sang
2025-01-05 3:38 ` Yury Norov
2025-01-05 9:35 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z3hTzvxp-Hzqnlj0@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=alexandre.belloni@bootlin.com \
--cc=david.laight.linux@gmail.com \
--cc=linux-i3c@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox